Refactor BasePageFetcher #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Contributor
|
@ajkannan great job, I just added some comments! |
ajkannan
force-pushed
the
basepagefetcher
branch
2 times, most recently
from
b1d2478 to
5628d7f
Compare
Author
|
Thanks for taking a look @mziccard! I made the fixes in place. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
ajkannan
force-pushed
the
basepagefetcher
branch
from
5628d7f to
cbdfecc
Compare
ajkannan
force-pushed
the
basepagefetcher
branch
from
cbdfecc to
ce9b5c1
Compare
Author
|
Added a commit to use the static method as @aozarov suggested. |
github-actions bot
pushed a commit
to suztomo/google-cloud-java
that referenced
this pull request
Jun 29, 2022
Committer: @miraleung PiperOrigin-RevId: 378266372 Source-Link: googleapis/googleapis@9e31055 Source-Link: https://github.com/googleapis/googleapis-gen/commit/14629f6b39dfee67009f79a96d2077d5bb17d1c3
github-actions bot
pushed a commit
that referenced
this pull request
Jul 6, 2022
🤖 I have created a release *beep* *boop* --- ## [0.14.1](googleapis/java-analytics-data@v0.14.0...v0.14.1) (2022-07-01) ### Dependencies * update dependency com.google.auth:google-auth-library-oauth2-http to v1.8.0 ([#511](googleapis/java-analytics-data#511)) ([8fe4a39](googleapis/java-analytics-data@8fe4a39)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot
pushed a commit
that referenced
this pull request
Jul 14, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
github-actions bot
pushed a commit
that referenced
this pull request
Aug 16, 2022
…-plugin to v3.4.1 (#517) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [org.apache.maven.plugins:maven-javadoc-plugin](https://maven.apache.org/plugins/) | `3.4.0` -> `3.4.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-retail). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNjEuMCIsInVwZGF0ZWRJblZlciI6IjMyLjE2MS4wIn0=-->
](https://renovatebot.com){kind=link}
github-actions bot
pushed a commit
that referenced
this pull request
Sep 15, 2022
🤖 I have created a release *beep* *boop* --- ## [2.5.3](googleapis/java-os-config@v2.5.2...v2.5.3) (2022-09-09) ### Dependencies * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#516](googleapis/java-os-config#516)) ([2b361ba](googleapis/java-os-config@2b361ba)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
🤖 I have created a release *beep* *boop* --- ### Updating meta-information for bleeding-edge SNAPSHOT release. --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin
pushed a commit
that referenced
this pull request
Dec 22, 2025
…-info-reports-plugin to v3.1.2 (#517)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #485