Skip to content

More Pubsub cleanup #4948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sduskis merged 3 commits into from
Apr 16, 2019
Merged

More Pubsub cleanup #4948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
17946de
More Pubsub cleanup
sduskis Apr 15, 2019
c9bdd2e
Merge branch 'master' into cleanup_pubsub_3
sduskis Apr 15, 2019
aa3f2a5
Reverting MessageDispatcher change.
sduskis Apr 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 0 additions & 55 deletions ...-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/PublisherStats.java
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion ...loud-clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/StatusUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ private StatusUtil() {
// Static class, not instantiable.
}

public static boolean isRetryable(Throwable error) {
static boolean isRetryable(Throwable error) {
if (!(error instanceof ApiException)) {
return true;
}
Expand Down
36 changes: 18 additions & 18 deletions ...clients/google-cloud-pubsub/src/main/java/com/google/cloud/pubsub/v1/SubscriberStats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,52 +27,52 @@ abstract class SubscriberStats {

@AutoValue
// TODO: Finish implementation.
public abstract static class Stats {}
abstract static class Stats {}

/** Number of successfully published messages. */
public abstract long getReceivedMessages();
abstract long getReceivedMessages();

/** Number of successfully published messages. */
public abstract long getAckedMessages();
abstract long getAckedMessages();

/** Number of received messages. */
public abstract long getTotalReceivedMessages();
abstract long getTotalReceivedMessages();

/** Number messages acked. */
public abstract long getTotalAckedMessages();
abstract long getTotalAckedMessages();

/** End to end latency. */
public abstract Stats getEndToEndLatency();
abstract Stats getEndToEndLatency();

/**
* Acknowledgement latency; time in between the message has been received and then acknowledged or
* rejected.
*/
public abstract Stats getAckLatency();
abstract Stats getAckLatency();

/** Number of messages for which we have auto extended its acknowledgement deadline. */
public abstract long getNumberOfAutoExtendedAckDeadlines();
abstract long getNumberOfAutoExtendedAckDeadlines();

public static Builder newBuilder() {
static Builder newBuilder() {
return new AutoValue_SubscriberStats.Builder();
}

@AutoValue.Builder
public abstract static class Builder {
public abstract Builder setReceivedMessages(long value);
abstract static class Builder {
abstract Builder setReceivedMessages(long value);

public abstract Builder setAckedMessages(long value);
abstract Builder setAckedMessages(long value);

public abstract Builder setTotalReceivedMessages(long value);
abstract Builder setTotalReceivedMessages(long value);

public abstract Builder setTotalAckedMessages(long value);
abstract Builder setTotalAckedMessages(long value);

public abstract Builder setEndToEndLatency(Stats value);
abstract Builder setEndToEndLatency(Stats value);

public abstract Builder setAckLatency(Stats value);
abstract Builder setAckLatency(Stats value);

public abstract Builder setNumberOfAutoExtendedAckDeadlines(long value);
abstract Builder setNumberOfAutoExtendedAckDeadlines(long value);

public abstract SubscriberStats build();
abstract SubscriberStats build();
}
}