Skip to content

Bigtable: Deemphasize most of the settings and move them to the StubSettings #4509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
igorbernstein2 merged 5 commits into from
Feb 20, 2019
Merged

Bigtable: Deemphasize most of the settings and move them to the StubSettings #4509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0fae43f
Bigtable: Deemphasize most of the settings and move them to the StubS…
igorbernstein2 Feb 15, 2019
2d535f5
Merge remote-tracking branch 'origin/master' into settings--5
igorbernstein2 Feb 17, 2019
c679198
Merge remote-tracking branch 'origin/master' into settings--5
igorbernstein2 Feb 20, 2019
f752c42
format
igorbernstein2 Feb 20, 2019
656a175
fix bad merge
igorbernstein2 Feb 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/BigtableDataClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public static BigtableDataClient create(String projectId, String instanceId) thr
* created based on the settings passed in, or defaults for any settings that are not set.
*/
public static BigtableDataClient create(BigtableDataSettings settings) throws IOException {
EnhancedBigtableStub stub = EnhancedBigtableStub.create(settings.getTypedStubSettings());
EnhancedBigtableStub stub = EnhancedBigtableStub.create(settings.getStubSettings());
return new BigtableDataClient(stub);
}

Expand Down
Loading