Skip to content

Pub/Sub: default values in batch settings comments #4350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anguillanneuf merged 2 commits into from
Jan 16, 2019
Merged

Pub/Sub: default values in batch settings comments #4350

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b33916
Pub/Sub: default values in batch settings comments
anguillanneuf Jan 16, 2019
424599b
Verbose comment
anguillanneuf Jan 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...d-examples/src/main/java/com/google/cloud/examples/pubsub/snippets/PublisherSnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@ public Publisher getPublisherWithCustomBatchSettings(ProjectTopicName topicName)
throws Exception {
// [START pubsub_publisher_batch_settings]
// Batch settings control how the publisher batches messages
long requestBytesThreshold = 5000L; // default : 1kb
long messageCountBatchSize = 10L; // default : 100
long requestBytesThreshold = 5000L; // default : 1 byte
long messageCountBatchSize = 10L; // default : 1 message

Duration publishDelayThreshold = Duration.ofMillis(100); // default : 1 ms

Expand Down