Skip to content

Delay download of Bigtable emulator #4102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chingor13 merged 3 commits into from
Nov 26, 2018
Merged

Delay download of Bigtable emulator #4102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d00b7e7
Add gcloud.download.skip option for google-cloud-gcloud-maven-plugin
chingor13 Nov 26, 2018
3dda3b4
Skip emulator download when doing the initial install
chingor13 Nov 26, 2018
6533229
Rename `skip` to `shouldSkipDownload`
chingor13 Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .kokoro/build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ cd github/google-cloud-java/
java -version
echo $JOB_TYPE

mvn install -DskipTests=true -Dmaven.javadoc.skip=true -B -V
mvn install -DskipTests=true -Dmaven.javadoc.skip=true -Dgcloud.download.skip=true -B -V

# prepend Kokoro root directory onto GOOGLE_APPLICATION_CREDENTIALS path
if [ ! -z "$GOOGLE_APPLICATION_CREDENTIALS" ]; then
Expand Down
7 changes: 7 additions & 0 deletions ...ogle-cloud-gcloud-maven-plugin/src/main/java/com/google/cloud/DownloadComponentsMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,17 @@ public class DownloadComponentsMojo extends AbstractMojo {
@Parameter(defaultValue = "false", required = true, property = "gcloud.download.force")
private boolean forceRefresh;

@Parameter(defaultValue = "false", required = true, property = "gcloud.download.skip")
private boolean shouldSkipDownload;

@Parameter(defaultValue = "${session}", readonly = true)
private MavenSession session;

public void execute() throws MojoExecutionException {
if (shouldSkipDownload) {
return;
}

if (session.isOffline() && forceRefresh) {
throw new MojoExecutionException("Can't force refresh when offline");
}
Expand Down