Skip to content

make storage batch request honor options.getHost() #3340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yihanzhen merged 1 commit into from
Jun 4, 2018
Merged

make storage batch request honor options.getHost() #3340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ts/google-cloud-storage/src/main/java/com/google/cloud/storage/spi/v1/HttpStorageRpc.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public void submit() {
// TODO(hailongwen@): instrument 'google-api-java-client' to further break down the span.
// Here we only add a annotation to at least know how much time each batch takes.
span.addAnnotation("Execute batch request");
batch.setBatchUrl(new GenericUrl("https://www.googleapis.com/batch/storage/v1"));
batch.setBatchUrl(new GenericUrl(String.format("%s/batch/storage/v1", options.getHost())));
batch.execute();
}
} catch (IOException ex) {
Expand Down