Skip to content

add newBuilder() to logging.SourceLocation #3339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yihanzhen merged 2 commits into from
Jun 4, 2018
Merged

add newBuilder() to logging.SourceLocation #3339

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a991b1f
add newBuilder() to logging.SourceLocation
yihanzhen Jun 4, 2018
e42df39
fix code review
yihanzhen Jun 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...d-clients/google-cloud-logging/src/main/java/com/google/cloud/logging/SourceLocation.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ public final class SourceLocation implements Serializable {
private final Long line;
private final String function;

public static Builder newBuilder() {
return new Builder();
}

/**
* A builder for {@code SourceLocation} objects.
*/
Expand Down
2 changes: 1 addition & 1 deletion ...ients/google-cloud-logging/src/test/java/com/google/cloud/logging/SourceLocationTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class SourceLocationTest {
private static final String FILE = "file";
private static final Long LINE = 42L;
private static final String FUNCTION = "function";
private static final SourceLocation SOURCE_LOCATION = new SourceLocation.Builder()
private static final SourceLocation SOURCE_LOCATION = SourceLocation.newBuilder()
.setFile(FILE)
.setLine(LINE)
.setFunction(FUNCTION)
Expand Down