Skip to content

bigquery: unbox Boolean in examples #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pongad merged 1 commit into from
May 9, 2018
Merged

bigquery: unbox Boolean in examples #3248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/BigQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -671,7 +671,7 @@ public int hashCode() {
* <p>Example of deleting a dataset from its id, even if non-empty.
* <pre> {@code
* String datasetName = "my_dataset_name";
* Boolean deleted = bigquery.delete(datasetName, DatasetDeleteOption.deleteContents());
* boolean deleted = bigquery.delete(datasetName, DatasetDeleteOption.deleteContents());
* if (deleted) {
* // the dataset was deleted
* } else {
Expand All @@ -692,7 +692,7 @@ public int hashCode() {
* String projectId = "my_project_id";
* String datasetName = "my_dataset_name";
* DatasetId datasetId = DatasetId.of(projectId, datasetName);
* Boolean deleted = bigquery.delete(datasetId, DatasetDeleteOption.deleteContents());
* boolean deleted = bigquery.delete(datasetId, DatasetDeleteOption.deleteContents());
* if (deleted) {
* // the dataset was deleted
* } else {
Expand All @@ -712,7 +712,7 @@ public int hashCode() {
* <pre> {@code
* String datasetName = "my_dataset_name";
* String tableName = "my_table_name";
* Boolean deleted = bigquery.delete(datasetName, tableName);
* boolean deleted = bigquery.delete(datasetName, tableName);
* if (deleted) {
* // the table was deleted
* } else {
Expand All @@ -734,7 +734,7 @@ public int hashCode() {
* String datasetName = "my_dataset_name";
* String tableName = "my_table_name";
* TableId tableId = TableId.of(projectId, datasetName, tableName);
* Boolean deleted = bigquery.delete(tableId);
* boolean deleted = bigquery.delete(tableId);
* if (deleted) {
* // the table was deleted
* } else {
Expand Down
16 changes: 8 additions & 8 deletions ...-examples/src/main/java/com/google/cloud/examples/bigquery/snippets/BigQuerySnippets.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,9 +168,9 @@ public Page<Dataset> listDatasets(String projectId) {
*/
// [TARGET delete(String, DatasetDeleteOption...)]
// [VARIABLE "my_dataset_name"]
public Boolean deleteDataset(String datasetName) {
public boolean deleteDataset(String datasetName) {
// [START ]
Boolean deleted = bigquery.delete(datasetName, DatasetDeleteOption.deleteContents());
boolean deleted = bigquery.delete(datasetName, DatasetDeleteOption.deleteContents());
if (deleted) {
// the dataset was deleted
} else {
Expand All @@ -186,10 +186,10 @@ public Boolean deleteDataset(String datasetName) {
// [TARGET delete(DatasetId, DatasetDeleteOption...)]
// [VARIABLE "my_project_id"]
// [VARIABLE "my_dataset_name"]
public Boolean deleteDatasetFromId(String projectId, String datasetName) {
public boolean deleteDatasetFromId(String projectId, String datasetName) {
// [START bigquery_delete_dataset]
DatasetId datasetId = DatasetId.of(projectId, datasetName);
Boolean deleted = bigquery.delete(datasetId, DatasetDeleteOption.deleteContents());
boolean deleted = bigquery.delete(datasetId, DatasetDeleteOption.deleteContents());
if (deleted) {
// the dataset was deleted
} else {
Expand All @@ -205,9 +205,9 @@ public Boolean deleteDatasetFromId(String projectId, String datasetName) {
// [TARGET delete(String, String)]
// [VARIABLE "my_dataset_name"]
// [VARIABLE "my_table_name"]
public Boolean deleteTable(String datasetName, String tableName) {
public boolean deleteTable(String datasetName, String tableName) {
// [START ]
Boolean deleted = bigquery.delete(datasetName, tableName);
boolean deleted = bigquery.delete(datasetName, tableName);
if (deleted) {
// the table was deleted
} else {
Expand All @@ -224,10 +224,10 @@ public Boolean deleteTable(String datasetName, String tableName) {
// [VARIABLE "my_project_id"]
// [VARIABLE "my_dataset_name"]
// [VARIABLE "my_table_name"]
public Boolean deleteTableFromId(String projectId, String datasetName, String tableName) {
public boolean deleteTableFromId(String projectId, String datasetName, String tableName) {
// [START bigquery_delete_table]
TableId tableId = TableId.of(projectId, datasetName, tableName);
Boolean deleted = bigquery.delete(tableId);
boolean deleted = bigquery.delete(tableId);
if (deleted) {
// the table was deleted
} else {
Expand Down