Increase Java compiler heap size to 1024m #3184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Contributor
Author
|
@pongad PTAL (or delegate to someone else)? |
pongad
approved these changes
Apr 25, 2018
Contributor
pongad
left a comment
pongad
left a comment
There was a problem hiding this comment.
I'm good with this, but should we increase the limit on other JVMs as well?
Contributor
Author
|
I'll wait until the other JVMs throw an out of memory exception to increase the limit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCE Java PR CI build for java 7 (#3100) fails due to an out of memory error during compilation, e.g. https://circleci.com/gh/GoogleCloudPlatform/google-cloud-java/4768.
Increasing the heap size fixes that build.