Skip to content

Add options parameter to Blob.exists #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aozarov merged 1 commit into from
Oct 14, 2015
Merged

Add options parameter to Blob.exists #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions gcloud-java-storage/src/main/java/com/google/gcloud/storage/Blob.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,11 +150,12 @@ public BlobId id() {
/**
* Checks if this blob exists.
*
* @param options blob read options
* @return true if this blob exists, false otherwise
* @throws StorageException upon failure
*/
public boolean exists() {
return storage.get(info.blobId()) != null;
public boolean exists(BlobSourceOption... options) {
return storage.get(info.blobId(), convert(info, options)) != null;
}

/**
Expand Down
4 changes: 2 additions & 2 deletions gcloud-java-storage/src/test/java/com/google/gcloud/storage/BlobTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,14 @@ public void testInfo() throws Exception {

@Test
public void testExists_True() throws Exception {
expect(storage.get(BLOB_INFO.blobId())).andReturn(BLOB_INFO);
expect(storage.get(BLOB_INFO.blobId(), new Storage.BlobSourceOption[0])).andReturn(BLOB_INFO);
replay(storage);
assertTrue(blob.exists());
}

@Test
public void testExists_False() throws Exception {
expect(storage.get(BLOB_INFO.blobId())).andReturn(null);
expect(storage.get(BLOB_INFO.blobId(), new Storage.BlobSourceOption[0])).andReturn(null);
replay(storage);
assertFalse(blob.exists());
}
Expand Down