Skip to content

Conversation

@pongad
Copy link
Contributor

@pongad pongad commented Jan 18, 2017

This reflects the changes in googleapis/googleapis#241 but pulls in other changes that landed in master by #1501

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 18, 2017
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 83.149% when pulling ffa822b on pongad:package-private into 19acb03 on GoogleCloudPlatform:pubsub-rm.

@garrettjonesgoogle
Copy link
Member

LGTM

@garrettjonesgoogle
Copy link
Member

Hmm it looks like the Travis Mac run had the same failure as another of your PRs.

@pongad
Copy link
Contributor Author

pongad commented Jan 18, 2017

As discussed, we can merge to pubsub-hp, but we'll definitely hold off merging to master until we fix the flakes.

@pongad pongad merged commit 1f68932 into googleapis:pubsub-rm Jan 18, 2017
@pongad pongad deleted the package-private branch January 18, 2017 23:19
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants