Support enumeration of filesystems when credentials are not available #1189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
| import org.junit.Test; | ||
| import org.junit.rules.ExpectedException; | ||
| import org.junit.runner.RunWith; | ||
| import org.junit.runners.JUnit4; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @VisibleForTesting | ||
| public static void setGCloudOptions(StorageOptions newStorageOptions) { | ||
| storageOptions = newStorageOptions; | ||
| futureStorageOptions = newStorageOptions; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @Before | ||
| public void before() { | ||
| mockOptions = mock(StorageOptions.class); | ||
| when(mockOptions.service()).thenReturn(StorageOptions.defaultInstance().service()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| return MoreObjects.toStringHelper(this).add("storage", storage).toString(); | ||
| return "CloudStorageFileSystemProvider"; | ||
| //initStorage(); | ||
| //return MoreObjects.toStringHelper(this).add("storage", storage).toString(); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
| @Before | ||
| public void before() { | ||
| CloudStorageFileSystemProvider.setGCloudOptions(LocalStorageHelper.options()); | ||
| CloudStorageFileSystemProvider.setStorageOptions(LocalStorageHelper.options()); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
mziccard
changed the title
Contributor
|
Thanks @jean-philippe-martin great work! |
Author
|
Thank you @mziccard for the good and prompt review! |
github-actions bot
pushed a commit
that referenced
this pull request
Jul 28, 2022
…1189) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-core](https://togithub.com/googleapis/java-core) | `2.8.1` -> `2.8.3` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-core</summary> ### [`v2.8.3`](https://togithub.com/googleapis/java-core/blob/HEAD/CHANGELOG.md#​283-httpsgithubcomgoogleapisjava-corecomparev282v283-2022-07-26) [Compare Source](https://togithub.com/googleapis/java-core/compare/v2.8.1...v2.8.3) ##### Dependencies - update dependency com.google.api-client:google-api-client-bom to v2 ([#​868](https://togithub.com/googleapis/java-core/issues/868)) ([e117c40](https://togithub.com/googleapis/java-core/commit/e117c40f31acf16a45bdbeeb727ba26d80eb6a51)) - update dependency com.google.api:gax-bom to v2.18.4 ([#​864](https://togithub.com/googleapis/java-core/issues/864)) ([bd40b1d](https://togithub.com/googleapis/java-core/commit/bd40b1d1b36cdcfa833047609e2488594b112be1)) - update dependency com.google.api:gax-bom to v2.18.5 ([#​876](https://togithub.com/googleapis/java-core/issues/876)) ([d8dc7fb](https://togithub.com/googleapis/java-core/commit/d8dc7fbdb0d65e493ca4154658c63e80d89ab600)) - update dependency com.google.api.grpc:proto-google-common-protos to v2.9.2 ([#​870](https://togithub.com/googleapis/java-core/issues/870)) ([7e961e9](https://togithub.com/googleapis/java-core/commit/7e961e945d5e049a1a1bb2592e9c155b5937e33b)) - update dependency com.google.api.grpc:proto-google-iam-v1 to v1.5.2 ([#​865](https://togithub.com/googleapis/java-core/issues/865)) ([fe7b974](https://togithub.com/googleapis/java-core/commit/fe7b974a0eae82711ca96edf412944309d5d6202)) - update dependency com.google.auth:google-auth-library-bom to v1.8.1 ([#​856](https://togithub.com/googleapis/java-core/issues/856)) ([92df5d3](https://togithub.com/googleapis/java-core/commit/92df5d3c248214970d38432e8c264d151298d1e6)) - update dependency com.google.http-client:google-http-client-bom to v1.42.2 ([#​871](https://togithub.com/googleapis/java-core/issues/871)) ([1972e8e](https://togithub.com/googleapis/java-core/commit/1972e8e45e11597e56609aa5fcd44e61958d5857)) - update dependency com.google.protobuf:protobuf-bom to v3.21.3 ([#​874](https://togithub.com/googleapis/java-core/issues/874)) ([1e18977](https://togithub.com/googleapis/java-core/commit/1e18977820ac766157156fb6246bd318d207971c)) - update dependency com.google.protobuf:protobuf-bom to v3.21.4 ([#​877](https://togithub.com/googleapis/java-core/issues/877)) ([d12fb5e](https://togithub.com/googleapis/java-core/commit/d12fb5e4eb8aa42015df84abf31f56408c8b64d8)) - update dependency io.grpc:grpc-bom to v1.48.0 ([#​873](https://togithub.com/googleapis/java-core/issues/873)) ([a45b075](https://togithub.com/googleapis/java-core/commit/a45b075e414049550c51ff0097337e45128fc499)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-automl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjcuNCIsInVwZGF0ZWRJblZlciI6IjMyLjEyNy40In0=-->
github-actions bot
pushed a commit
that referenced
this pull request
Aug 9, 2022
](https://renovatebot.com){kind=link}
🤖 I have created a release *beep* *boop* --- ## [2.3.3](googleapis/java-automl@v2.3.2...v2.3.3) (2022-08-09) ### Dependencies * update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1195](googleapis/java-automl#1195)) ([e676c4c](googleapis/java-automl@e676c4c)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1203](googleapis/java-automl#1203)) ([b6d75e2](googleapis/java-automl@b6d75e2)) * update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1205](googleapis/java-automl#1205)) ([18ee6b6](googleapis/java-automl@18ee6b6)) * update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#1189](googleapis/java-automl#1189)) ([90f3232](googleapis/java-automl@90f3232)) * update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#1190](googleapis/java-automl#1190)) ([77b2a7d](googleapis/java-automl@77b2a7d)) * update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#1191](googleapis/java-automl#1191)) ([f6f08ba](googleapis/java-automl@f6f08ba)) * update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#1197](googleapis/java-automl#1197)) ([9c1ff45](googleapis/java-automl@9c1ff45)) * update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#1199](googleapis/java-automl#1199)) ([7bd891b](googleapis/java-automl@7bd891b)) * update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#1201](googleapis/java-automl#1201)) ([026ae49](googleapis/java-automl@026ae49)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1192](googleapis/java-automl#1192)) ([94c1c3c](googleapis/java-automl@94c1c3c)) * update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.1 ([#1198](googleapis/java-automl#1198)) ([1be2ead](googleapis/java-automl@1be2ead)) * update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1196](googleapis/java-automl#1196)) ([73871d6](googleapis/java-automl@73871d6)) * update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1200](googleapis/java-automl#1200)) ([ea4490e](googleapis/java-automl@ea4490e)) * update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1202](googleapis/java-automl#1202)) ([3c8f71e](googleapis/java-automl@3c8f71e)) * update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1204](googleapis/java-automl#1204)) ([cc4d715](googleapis/java-automl@cc4d715)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
chingor13
pushed a commit
that referenced
this pull request
Jan 6, 2026
…25.0 (#1189) [](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [com.google.cloud:libraries-bom](https://cloud.google.com/java/docs/bom) ([source](https://togithub.com/googleapis/java-cloud-bom)) | `26.24.0` -> `26.25.0` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>googleapis/java-cloud-bom (com.google.cloud:libraries-bom)</summary> ### [`v26.25.0`](https://togithub.com/googleapis/java-cloud-bom/blob/HEAD/CHANGELOG.md#26250-2023-10-14) [Compare Source](https://togithub.com/googleapis/java-cloud-bom/compare/v26.24.0...v26.25.0) ##### Dependencies - update dependency com.google.cloud:first-party-dependencies to v3.17.0 ([#​6226](https://togithub.com/googleapis/java-cloud-bom/issues/6226)) ([df72701](https://togithub.com/googleapis/java-cloud-bom/commit/df72701ecb3b339cdc1b3af9d137de7d95ed50aa)) - update dependency com.google.cloud:gapic-libraries-bom to v1.22.0 ([#​6240](https://togithub.com/googleapis/java-cloud-bom/issues/6240)) ([addef06](https://togithub.com/googleapis/java-cloud-bom/commit/addef066873995631b99009f8ea6f7cd58088b5f)) - update dependency com.google.cloud:google-cloud-bigquery to v2.33.2 ([#​6236](https://togithub.com/googleapis/java-cloud-bom/issues/6236)) ([68c7e4e](https://togithub.com/googleapis/java-cloud-bom/commit/68c7e4e4197db0da9d776b93d1fe0efdaa3165db)) - update dependency com.google.cloud:google-cloud-bigquerystorage-bom to v2.44.0 ([#​6235](https://togithub.com/googleapis/java-cloud-bom/issues/6235)) ([53d1f18](https://togithub.com/googleapis/java-cloud-bom/commit/53d1f18c3f63e28a69db44e37724b7eba6146bc9)) - update dependency com.google.cloud:google-cloud-bigtable-bom to v2.28.0 ([#​6241](https://togithub.com/googleapis/java-cloud-bom/issues/6241)) ([9b145d6](https://togithub.com/googleapis/java-cloud-bom/commit/9b145d6e3883fe91a78d7b097be1358d34e41d54)) - update dependency com.google.cloud:google-cloud-datastore-bom to v2.17.3 ([#​6228](https://togithub.com/googleapis/java-cloud-bom/issues/6228)) ([f2d317d](https://togithub.com/googleapis/java-cloud-bom/commit/f2d317def4b5f7f5e924136acbd07314976ef15e)) - update dependency com.google.cloud:google-cloud-firestore-bom to v3.15.1 ([#​6233](https://togithub.com/googleapis/java-cloud-bom/issues/6233)) ([43553e8](https://togithub.com/googleapis/java-cloud-bom/commit/43553e81ffc9d134652e8da7995917e11a9ae5c6)) - update dependency com.google.cloud:google-cloud-logging-bom to v3.15.11 ([#​6230](https://togithub.com/googleapis/java-cloud-bom/issues/6230)) ([6e9467a](https://togithub.com/googleapis/java-cloud-bom/commit/6e9467a4fa2c3e42b92792b3c8266d72e4982722)) - update dependency com.google.cloud:google-cloud-logging-logback to v0.130.24-alpha ([#​6234](https://togithub.com/googleapis/java-cloud-bom/issues/6234)) ([16a9be9](https://togithub.com/googleapis/java-cloud-bom/commit/16a9be91e49cf82c20d6bea56fd25c3905b2b14f)) - update dependency com.google.cloud:google-cloud-nio to v0.127.5 ([#​6238](https://togithub.com/googleapis/java-cloud-bom/issues/6238)) ([db7424d](https://togithub.com/googleapis/java-cloud-bom/commit/db7424d9b1368e5f437dcbc5f14a0b2e6d5cd0b2)) - update dependency com.google.cloud:google-cloud-pubsub-bom to v1.125.6 ([#​6231](https://togithub.com/googleapis/java-cloud-bom/issues/6231)) ([6a2418b](https://togithub.com/googleapis/java-cloud-bom/commit/6a2418be05d99470831dcf1ba3b1f0927cdfdd30)) - update dependency com.google.cloud:google-cloud-pubsublite-bom to v1.12.16 ([#​6239](https://togithub.com/googleapis/java-cloud-bom/issues/6239)) ([585750a](https://togithub.com/googleapis/java-cloud-bom/commit/585750a437826986c180b07f866a5133126f4455)) - update dependency com.google.cloud:google-cloud-spanner-bom to v6.50.1 ([#​6229](https://togithub.com/googleapis/java-cloud-bom/issues/6229)) ([9ce48f0](https://togithub.com/googleapis/java-cloud-bom/commit/9ce48f0a0967ce164a61fe8d8f63bbbdddbaf664)) - update dependency com.google.cloud:google-cloud-spanner-jdbc to v2.14.0 ([#​6242](https://togithub.com/googleapis/java-cloud-bom/issues/6242)) ([ff93f99](https://togithub.com/googleapis/java-cloud-bom/commit/ff93f99ebfdc0226a59487cb8c91e4baaac96bcd)) - update dependency com.google.cloud:google-cloud-storage-bom to v2.28.0 ([#​6243](https://togithub.com/googleapis/java-cloud-bom/issues/6243)) ([a2a0d44](https://togithub.com/googleapis/java-cloud-bom/commit/a2a0d44b9f1dacbd964ef15939eb9f02805093f4)) - update dependency com.google.googlejavaformat:google-java-format to v1.18.1 ([#​6221](https://togithub.com/googleapis/java-cloud-bom/issues/6221)) ([8a07930](https://togithub.com/googleapis/java-cloud-bom/commit/8a07930be3b3f86536af5dc0fb6906401772fd08)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/googleapis/java-logging-logback). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy44LjEiLCJ1cGRhdGVkSW5WZXIiOiIzNy4xOS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should resolve issue #1188.
One possible point of discussion is that I have left in the tests I used to reproduce the problem and ensure that it was fixed. These tests are only meaningful when gcloud is NOT configured (the opposite requirement of our integration tests) so I have them disabled here, with the intention that they ease manual testing by un-configuring gcloud and running those tests by hand. It would be great if there were a good way to run these tests automatically.
While I was at it I added a friendly message to the integration tests in case someone tries to run them before configuring gcloud.