Skip to content

Fix StreamingBuffer to allow oldestEntryTime to be null #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mziccard merged 1 commit into from
Aug 9, 2016
Merged

Fix StreamingBuffer to allow oldestEntryTime to be null #1141

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions gcloud-java-bigquery/src/main/java/com/google/cloud/bigquery/StandardTableDefinition.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ public static class StreamingBuffer implements Serializable {
private static final long serialVersionUID = 822027055549277843L;
private final long estimatedRows;
private final long estimatedBytes;
private final long oldestEntryTime;
private final Long oldestEntryTime;

StreamingBuffer(long estimatedRows, long estimatedBytes, long oldestEntryTime) {
StreamingBuffer(long estimatedRows, long estimatedBytes, Long oldestEntryTime) {
this.estimatedRows = estimatedRows;
this.estimatedBytes = estimatedBytes;
this.oldestEntryTime = oldestEntryTime;
Expand All @@ -77,9 +77,9 @@ public long estimatedBytes() {

/**
* Returns the timestamp of the oldest entry in the streaming buffer, in milliseconds since
* epoch.
* epoch. Returns {@code null} if the streaming buffer is empty.
*/
public long oldestEntryTime() {
public Long oldestEntryTime() {
return oldestEntryTime;
}

Expand Down Expand Up @@ -111,9 +111,13 @@ Streamingbuffer toPb() {
}

static StreamingBuffer fromPb(Streamingbuffer streamingBufferPb) {
Long oldestEntryTime = null;
if (streamingBufferPb.getOldestEntryTime() != null) {
oldestEntryTime = streamingBufferPb.getOldestEntryTime().longValue();
}
return new StreamingBuffer(streamingBufferPb.getEstimatedRows().longValue(),
streamingBufferPb.getEstimatedBytes().longValue(),
streamingBufferPb.getOldestEntryTime().longValue());
oldestEntryTime);
}
}

Expand Down