Skip to content

Hide string setter for DeprecationStatus timestamps #1127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mziccard merged 1 commit into from
Aug 9, 2016
Merged

Hide string setter for DeprecationStatus timestamps #1127

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions gcloud-java-compute/src/main/java/com/google/cloud/compute/DeprecationStatus.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ public static final class Builder<T extends ResourceId> {
*
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
*/
// todo(mziccard): remove this method if #732 is closed
public Builder<T> deleted(String deleted) {
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
Builder<T> deleted(String deleted) {
this.deleted = deleted;
return this;
}
Expand All @@ -108,8 +108,8 @@ public Builder<T> deleted(String deleted) {
*
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
*/
// todo(mziccard): remove this method if #732 is closed
public Builder<T> deprecated(String deprecated) {
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
Builder<T> deprecated(String deprecated) {
this.deprecated = deprecated;
return this;
}
Expand All @@ -120,8 +120,8 @@ public Builder<T> deprecated(String deprecated) {
*
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
*/
// todo(mziccard): remove this method if #732 is closed
public Builder<T> obsolete(String obsolete) {
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
Builder<T> obsolete(String obsolete) {
this.obsolete = obsolete;
return this;
}
Expand Down Expand Up @@ -193,7 +193,7 @@ public DeprecationStatus<T> build() {
*
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
*/
// todo(mziccard): remove this method if #732 is closed
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
public String deleted() {
return deleted;
}
Expand All @@ -205,7 +205,7 @@ public String deleted() {
*
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
*/
// todo(mziccard): remove this method if #732 is closed
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
public String deprecated() {
return deprecated;
}
Expand All @@ -217,7 +217,7 @@ public String deprecated() {
*
* @see <a href="http://www.ietf.org/rfc/rfc3339.txt">RFC3339</a>
*/
// todo(mziccard): remove this method if #732 is closed
// Wrongly-formatted timestamps were allowed, we must still support them (see #732 for details)
public String obsolete() {
return obsolete;
}
Expand Down