Skip to content

Conversation

@mziccard
Copy link
Contributor

As per title this PR adds tests and javadoc for PushConfig. This also adds two minor fixes for Message's javadoc and tests.

@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label May 12, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 12, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 82.898% when pulling d74fa71 on mziccard:pubsub-pushconfig into 6e0c6c0 on GoogleCloudPlatform:pubsub-alpha.

@mziccard
Copy link
Contributor Author

/cc @jgeewax @lesv

@lesv
Copy link
Contributor

lesv commented May 12, 2016

LGTM - It's going to take me a bit to get more picky on things. I like the changes.
I will probably add CheckStyle against Google standards before EoQ.

@mziccard
Copy link
Contributor Author

I will probably add CheckStyle against Google standards before EoQ.

Would be cool. Thanks for the pass.

@mziccard mziccard merged commit 1eded7e into googleapis:pubsub-alpha May 12, 2016
mziccard added a commit to mziccard/gcloud-java that referenced this pull request Jun 27, 2016
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
…0.0 (#1004)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-storage](https://togithub.com/googleapis/java-storage) | `2.7.0` -> `2.10.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.10.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.10.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.10.0/compatibility-slim/2.7.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.10.0/confidence-slim/2.7.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-storage</summary>

### [`v2.10.0`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;2100-httpsgithubcomgoogleapisjava-storagecomparev293v2100-2022-07-13)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.9.3...v2.10.0)

##### Features

-   Custom Placement Config Dual Region Support ([#&#8203;1470](https://togithub.com/googleapis/java-storage/issues/1470)) ([36440fc](https://togithub.com/googleapis/java-storage/commit/36440fc587976acc78f4dae480214b80ad3fc477))

##### Bug Fixes

-   enable longpaths support for windows test ([#&#8203;1485](https://togithub.com/googleapis/java-storage/issues/1485)) ([#&#8203;1506](https://togithub.com/googleapis/java-storage/issues/1506)) ([e36e809](https://togithub.com/googleapis/java-storage/commit/e36e80934644ccd5e873754c625367f24e5fc7f3))

##### Documentation

-   **sample:** upgrade maven-surefire and remove junit-platform-native ([#&#8203;1476](https://togithub.com/googleapis/java-storage/issues/1476)) ([9b222e4](https://togithub.com/googleapis/java-storage/commit/9b222e483937bd0639123899442c1e863683718a))

##### Dependencies

-   update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.13 ([#&#8203;1501](https://togithub.com/googleapis/java-storage/issues/1501)) ([36e3898](https://togithub.com/googleapis/java-storage/commit/36e389857ea3f86350af5763c829e5f1caaaa3ec))

### [`v2.9.3`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;293-httpsgithubcomgoogleapisjava-storagecomparev292v293-2022-07-08)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.9.2...v2.9.3)

##### Dependencies

-   update dependency com.google.apis:google-api-services-storage to v1-rev20220705-1.32.1 ([#&#8203;1494](https://togithub.com/googleapis/java-storage/issues/1494)) ([5612f0f](https://togithub.com/googleapis/java-storage/commit/5612f0f929582c9e720d67683f9441d96080fb14))

### [`v2.9.2`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;292-httpsgithubcomgoogleapisjava-storagecomparev291v292-2022-07-06)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.9.1...v2.9.2)

##### Dependencies

-   update kms.version to v0.97.0 ([#&#8203;1488](https://togithub.com/googleapis/java-storage/issues/1488)) ([852cafe](https://togithub.com/googleapis/java-storage/commit/852cafe7db018a6fd666c3490c96eeca34c4a1ed))

### [`v2.9.1`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;291-httpsgithubcomgoogleapisjava-storagecomparev290v291-2022-07-06)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.9.0...v2.9.1)

##### Dependencies

-   update dependency com.google.cloud:google-cloud-pubsub to v1.120.0 ([#&#8203;1487](https://togithub.com/googleapis/java-storage/issues/1487)) ([5a8f6e5](https://togithub.com/googleapis/java-storage/commit/5a8f6e5f29e4dfb2dc03cad8c77e4b504bc83019))

### [`v2.9.0`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;290-httpsgithubcomgoogleapisjava-storagecomparev281v290-2022-06-27)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.8.1...v2.9.0)

##### Features

-   Enable REST transport for most of Java and Go clients ([#&#8203;1469](https://togithub.com/googleapis/java-storage/issues/1469)) ([cfb6fd8](https://togithub.com/googleapis/java-storage/commit/cfb6fd8c1f13cb2115e5ff7ea7af41a9e27986b1))

##### Documentation

-   Clarified how clients should work with resumable uploads ([#&#8203;1457](https://togithub.com/googleapis/java-storage/issues/1457)) ([15baa27](https://togithub.com/googleapis/java-storage/commit/15baa27c97aacca115981f5c14d942a8ddd6cb1f))

##### Dependencies

-   update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#&#8203;1468](https://togithub.com/googleapis/java-storage/issues/1468)) ([1a817fe](https://togithub.com/googleapis/java-storage/commit/1a817fef87e626e74dab47eaff33c1d9d3c56bb5))
-   update dependency org.graalvm.buildtools:junit-platform-native to v0.9.12 ([#&#8203;1463](https://togithub.com/googleapis/java-storage/issues/1463)) ([d42c570](https://togithub.com/googleapis/java-storage/commit/d42c5704e4fe7341dfdd0562fa0bdbcd4bc99c7e))
-   update dependency org.graalvm.buildtools:native-maven-plugin to v0.9.12 ([#&#8203;1464](https://togithub.com/googleapis/java-storage/issues/1464)) ([2f35a4f](https://togithub.com/googleapis/java-storage/commit/2f35a4f597870a4506119946510ba82fbb7f9449))
-   update kms.version to v0.96.3 ([#&#8203;1471](https://togithub.com/googleapis/java-storage/issues/1471)) ([ceb7fa6](https://togithub.com/googleapis/java-storage/commit/ceb7fa665c35f6b00aebaa665246597b9ee4632a))

### [`v2.8.1`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;281-httpsgithubcomgoogleapisjava-storagecomparev280v281-2022-06-13)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.8.0...v2.8.1)

##### Dependencies

-   update dependency com.google.apis:google-api-services-storage to v1-rev20220608-1.32.1 ([#&#8203;1448](https://togithub.com/googleapis/java-storage/issues/1448)) ([96676cd](https://togithub.com/googleapis/java-storage/commit/96676cd830aca27c23c08e02e8cc7c58dece686c))

### [`v2.8.0`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;280-httpsgithubcomgoogleapisjava-storagecomparev272v280-2022-06-08)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.7.2...v2.8.0)

##### Features

-   Prefix/Suffix Matches Lifecycle Condition ([#&#8203;1389](https://togithub.com/googleapis/java-storage/issues/1389)) ([20c8848](https://togithub.com/googleapis/java-storage/commit/20c88489d80d716da28f78fed628b54345f32ca4))
-   Support AbortIncompleteMultipartUpload LifecycleAction ([#&#8203;1347](https://togithub.com/googleapis/java-storage/issues/1347)) ([7c3aba2](https://togithub.com/googleapis/java-storage/commit/7c3aba2f0a26ac550e4f37f9287ed6b041d75919))

##### Bug Fixes

-   update request method of HttpStorageRpc to properly configure offset on requests ([#&#8203;1434](https://togithub.com/googleapis/java-storage/issues/1434)) ([72dc0df](https://togithub.com/googleapis/java-storage/commit/72dc0dff20d76875401dac721c0268c32e475e39))

##### Dependencies

-   update dependency com.google.apis:google-api-services-storage to v1-rev20220604-1.32.1 ([#&#8203;1438](https://togithub.com/googleapis/java-storage/issues/1438)) ([df8fcd9](https://togithub.com/googleapis/java-storage/commit/df8fcd9925ef06c91ebebe0a3a7b5aedeb15ec4d))
-   update dependency com.google.cloud:google-cloud-pubsub to v1.119.0 ([#&#8203;1426](https://togithub.com/googleapis/java-storage/issues/1426)) ([93ba28c](https://togithub.com/googleapis/java-storage/commit/93ba28cff16d428e0222078dc60dbf49fda7632a))

##### [2.7.2](https://togithub.com/googleapis/java-storage/compare/v2.7.1...v2.7.2) (2022-05-27)

##### Dependencies

-   update kms.version to v0.96.1 ([#&#8203;1418](https://togithub.com/googleapis/java-storage/issues/1418)) ([d2f325b](https://togithub.com/googleapis/java-storage/commit/d2f325b3d31ac5da367873be1fb530fb6356036a))

##### [2.7.1](https://togithub.com/googleapis/java-storage/compare/v2.7.0...v2.7.1) (2022-05-24)

##### Dependencies

-   update kms.version to v0.96.0 ([#&#8203;1408](https://togithub.com/googleapis/java-storage/issues/1408)) ([7501ffc](https://togithub.com/googleapis/java-storage/commit/7501ffc97d5a7943d3852ea26133b6c62cbbff1f))

### [`v2.7.2`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;272-httpsgithubcomgoogleapisjava-storagecomparev271v272-2022-05-27)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.7.1...v2.7.2)

### [`v2.7.1`](https://togithub.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;271-httpsgithubcomgoogleapisjava-storagecomparev270v271-2022-05-24)

[Compare Source](https://togithub.com/googleapis/java-storage/compare/v2.7.0...v2.7.1)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMzUuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEzNS4xIn0=-->
github-actions bot pushed a commit that referenced this pull request Aug 9, 2022
🤖 I have created a release *beep* *boop*
---


## [3.2.0](googleapis/java-aiplatform@v3.1.0...v3.2.0) (2022-08-09)


### Features

* add a DeploymentResourcePool API resource_definition ([#997](googleapis/java-aiplatform#997)) ([82551d8](googleapis/java-aiplatform@82551d8))
* add DeploymentResourcePool in aiplatform v1beta1 deployment_resource_pool.proto ([#998](googleapis/java-aiplatform#998)) ([76dc64f](googleapis/java-aiplatform@76dc64f))
* add DeploymentResourcePoolService in aiplatform v1beta1 deployment_resource_pool_service.proto ([76dc64f](googleapis/java-aiplatform@76dc64f))
* add shared_resources for supported prediction_resources ([82551d8](googleapis/java-aiplatform@82551d8))
* add SHARED_RESOURCES to DeploymentResourcesType in aiplatform v1beta1 model.proto ([76dc64f](googleapis/java-aiplatform@76dc64f))
* added SHARED_RESOURCES enum to aiplatform v1 model.proto ([301cfb0](googleapis/java-aiplatform@301cfb0))
* DeploymentResourcePool and DeployementResourcePoolService added to aiplatform v1beta1 model.proto (cl/463147866) ([301cfb0](googleapis/java-aiplatform@301cfb0))
* making network arg optional in aiplatform v1 custom_job.proto ([#999](googleapis/java-aiplatform#999)) ([301cfb0](googleapis/java-aiplatform@301cfb0))
* making network arg optional in aiplatform v1beta1 custom_job.proto ([301cfb0](googleapis/java-aiplatform@301cfb0))
* **samples:** add all feature samples ([#980](googleapis/java-aiplatform#980)) ([8c2a485](googleapis/java-aiplatform@8c2a485))
* **samples:** add all feature values samples ([#981](googleapis/java-aiplatform#981)) ([2d4e6fe](googleapis/java-aiplatform@2d4e6fe))


### Bug Fixes

* declaring test-scope artifact as runtime ([#1014](googleapis/java-aiplatform#1014)) ([6c47c65](googleapis/java-aiplatform@6c47c65))


### Documentation

* doc edits to aiplatform v1 dataset_service.proto, job_service.proto, model_service.proto, pipeline_service.proto, saved_query.proto, study.proto, types.proto ([301cfb0](googleapis/java-aiplatform@301cfb0))
* doc edits to aiplatform v1beta1 job_service.proto, model_service.proto, pipeline_service.proto, saved_query.proto, study.proto, types.proto ([301cfb0](googleapis/java-aiplatform@301cfb0))


### Dependencies

* update dependency com.google.api.grpc:proto-google-cloud-aiplatform-v1beta1 to v0.17.0 ([#1003](googleapis/java-aiplatform#1003)) ([b793732](googleapis/java-aiplatform@b793732))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1006](googleapis/java-aiplatform#1006)) ([6bb8982](googleapis/java-aiplatform@6bb8982))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1009](googleapis/java-aiplatform#1009)) ([8cca8b5](googleapis/java-aiplatform@8cca8b5))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1000](googleapis/java-aiplatform#1000)) ([c93de30](googleapis/java-aiplatform@c93de30))
* update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1004](googleapis/java-aiplatform#1004)) ([dd52cad](googleapis/java-aiplatform@dd52cad))
* update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1005](googleapis/java-aiplatform#1005)) ([60e2f76](googleapis/java-aiplatform@60e2f76))
* update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1008](googleapis/java-aiplatform#1008)) ([9a2fe64](googleapis/java-aiplatform@9a2fe64))
* update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1010](googleapis/java-aiplatform#1010)) ([3c2ac16](googleapis/java-aiplatform@3c2ac16))
* update dependency com.google.code.gson:gson to v2.9.1 ([#1001](googleapis/java-aiplatform#1001)) ([a6ffed4](googleapis/java-aiplatform@a6ffed4))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this pull request Oct 11, 2022
…orting to v0.124.15-beta (#1004)

* chore(deps): update dependency com.google.cloud:google-cloud-errorreporting to v0.124.15-beta

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
suztomo pushed a commit that referenced this pull request Feb 1, 2023
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
meltsufin pushed a commit that referenced this pull request Dec 22, 2025
* fix: Add explicit RunWith annotations on all tests

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Ben Creech <[email protected]>
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants