Skip to content

fix(spanner): correct chrono arithmetic in Interval integration test #15810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
prathmeshcc merged 3 commits into from
Dec 10, 2025
+9 −10
Merged

fix(spanner): correct chrono arithmetic in Interval integration test #15810

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
85a6816
fix(spanner): correct chrono arithmetic in Interval integration test …
prathmeshcc Dec 1, 2025
ff9d390
fix(spanner): correct chrono arithmetic in Interval integration test …
prathmeshcc Dec 1, 2025
53521db
Merge branch 'main' into fix/spanner-interval-test
prathmeshcc Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions google/cloud/spanner/integration_tests/data_types_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -530,16 +530,15 @@ SELECT ARRAY<INTERVAL>[INTERVAL '1-2 3 4:5:6.789123456' YEAR TO SECOND];)sql",

TEST_F(DataTypeIntegrationTest, SelectIntervalFromTimestampDiff) {
if (UsingEmulator()) GTEST_SKIP();
Interval expected_interval{
std::chrono::duration_cast<std::chrono::nanoseconds>(
std::chrono::hours(1))};
std::time_t now_seconds =
std::chrono::system_clock::to_time_t(std::chrono::system_clock::now());
std::time_t one_hour_later_seconds = now_seconds + 3600;

std::vector<std::vector<Timestamp>> const data = {std::vector<Timestamp>{
MakeTimestamp(MakeTime(now_seconds, 0)).value(),
MakeTimestamp(MakeTime(one_hour_later_seconds, 0)).value()}};

auto const t0 = std::chrono::system_clock::from_time_t(1234567890);
auto const t1 = t0 + std::chrono::hours(1);

Interval expected_interval{t1 - t0};

std::vector<std::vector<Timestamp>> const data = {
{MakeTimestamp(t0).value(), MakeTimestamp(t1).value()}};

auto result = WriteReadData(*client_, data, "ArrayTimestampValue");
EXPECT_THAT(result, IsOkAndHolds(UnorderedElementsAreArray(data)));

Expand Down