feat(storage): Support read_all in the async client #15303
+238
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15303 +/- ##
==========================================
- Coverage 93.02% 93.02% -0.01%
==========================================
Files 2403 2403
Lines 219424 219533 +109
==========================================
+ Hits 204128 204228 +100
- Misses 15296 15305 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
devbww
reviewed
Aug 13, 2025
shubham-up-47
had a problem deploying
to
external
GitHub Actions
Failure
Contributor
Author
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR fixes issue: #15140 which says to provide a function to convert
storage_experimental::AsyncReaderinto a singlefuture<StatusOr<ReadPayload>>. The functionality is already there in storage_experimental::ReadAll() method.This PR adds the method to a public header i.e. async client and updates the documentation.
This change is