Skip to content

Conversation

@tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented Aug 19, 2015

Added 2 keyword arguments; cache_discovery and cache. You can suppress caching by setting cache_discovery=False. You can inject your own caching module via the cache kwarg.

It automatically uses app engine memcache if it's detected. It's not a hard dependency. Then fall back to file based caching.

fixes #110

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 19, 2015
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 19, 2015

@nathanielmanistaatgoogle I'd appreciate it if you could take a look.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 20, 2015

@dhermes FYI

@dhermes
Copy link
Contributor

dhermes commented Aug 20, 2015

Wow. So happy this is coming (3 years later)!

/cc @wescpy This is what we talked about at SFPython

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Contributor

Please squash commits.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 20, 2015

Thanks for the comment @nathanielmanistaatgoogle

All addressed, PTAL

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 20, 2015

Let me write some tests. I'll update here once done.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 21, 2015

I added some tests in test_discovery. PTAL

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@nathanielmanistaatgoogle
Copy link
Contributor

@dhermes are you also reviewing this or just excited about it happening?

@dhermes
Copy link
Contributor

dhermes commented Aug 23, 2015

I am not reviewing.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 23, 2015

@nathanielmanistaatgoogle
I addressed your comments. PTAL

@nathanielmanistaatgoogle
Copy link
Contributor

Looks good. Are there more unit tests still to come or is this what you'd like to have merged?

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 23, 2015

@nathanielmanistaatgoogle Thanks!
I would like to add some unit tests for the cache module. I will likely write those early next week.

@nathanielmanistaatgoogle
Copy link
Contributor

Great; I'll hold steady until I hear more from you.

@tmatsuo tmatsuo force-pushed the master branch 2 times, most recently from 782ba62 to 1e10bfa Compare August 24, 2015 17:33
@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 24, 2015

I have just added a unit test for the file cache, which discovered several bugs in my code!

@nathanielmanistaatgoogle Now I'm confident to say "let's merge this". PTAL

This comment was marked as spam.

This comment was marked as spam.

nathanielmanistaatgoogle added a commit that referenced this pull request Aug 24, 2015
Implemented automatic caching for discovery documents.
@nathanielmanistaatgoogle nathanielmanistaatgoogle merged commit ed3d5a6 into googleapis:master Aug 24, 2015
@nathanielmanistaatgoogle
Copy link
Contributor

Thanks for the contribution!

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 24, 2015

Thanks for the review! I'm wondering when it goes to pypi distribution so that everyone can benefit from it.

@nathanielmanistaatgoogle
Copy link
Contributor

Likely not this week; we're swamped with other things. Perhaps toward the end of next week? Would that be acceptable? Otherwise "sometime in September"?

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Aug 24, 2015

Yeah, sounds good, thanks

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 3, 2015

Ok, will you be able to do the release this week? If you still have other things, maybe I can do the release, especially if there's how-to doc. Let me know if you want me to do.

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 10, 2015

To clarify, I have uploaded a small library to pypi before, so I know the basic. My username on pypi is tmatsuo, so maybe you can add me to the owners list of this package on pypi so that I can do the release?

My current guess for how to release is that:

  1. Create a release on github
  2. upload the package to testpypi first and do the sanity check
  3. upload it to pypi

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 14, 2015

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 24, 2015

@dhermes I haven't seen any issues with the new release for a week, so I removed your original article about cache on App Engine. Thanks!

@dhermes
Copy link
Contributor

dhermes commented Sep 24, 2015

You could have just marked it deprecated. Now I have one less imprint on Google Developers 😞

@tmatsuo
Copy link
Contributor Author

tmatsuo commented Sep 24, 2015

Yeah, in that sense, I initially tried to mark it as deprecated, but tech writers don't like it. You're doing a greater work on gcloud-python, so I thought you're ok, but let me know if you want it back strongly.

@dhermes
Copy link
Contributor

dhermes commented Sep 24, 2015

Ha no worries Takashi! I was just giving you a hard time. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion: discovery doc caching

4 participants