Add missing exception to the catch chain#1284
Merged
Merged
Conversation
googlebot
added
the
cla: yes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As stated by @vocoded on the issue #1279 firebase/php-jwt changed the way they report a problem with the certificate. If the signature is invalid, the verify function won't throw a
DomainExceptionand instead it will returnfalseand then the decode function will throw aSignatureInvalidException. This fix adds the later exception to the catch chain so it will continue trying with other certificates.I wasn't able to replicate the issue with a test but I try this fix on my project and it seems to had the problem fixed.
tl;dr
This fixes #1279