Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

@andreamlin
Copy link
Contributor

In case users want to ping on status code, we have to be aware of 200s.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@andreamlin
Copy link
Contributor Author

PTAL

Copy link
Contributor

@vam-google vam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreamlin andreamlin merged commit 7fa8133 into googleapis:master Feb 21, 2019
@andreamlin andreamlin deleted the 200 branch February 21, 2019 21:14
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #679 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #679      +/-   ##
============================================
- Coverage     75.71%   75.69%   -0.02%     
  Complexity     1029     1029              
============================================
  Files           194      194              
  Lines          4608     4609       +1     
  Branches        356      356              
============================================
  Hits           3489     3489              
- Misses          961      962       +1     
  Partials        158      158
Impacted Files Coverage Δ Complexity Δ
...om/google/api/gax/httpjson/HttpJsonStatusCode.java 26.82% <0%> (-0.68%) 7 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d41b922...f4796b0. Read the comment docs.

This was referenced Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants