Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

@elharo
Copy link
Contributor

@elharo elharo commented Feb 15, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 15, 2019
@codecov
Copy link

codecov bot commented Feb 15, 2019

Codecov Report

Merging #672 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #672   +/-   ##
=========================================
  Coverage     75.53%   75.53%           
  Complexity     1025     1025           
=========================================
  Files           192      192           
  Lines          4533     4533           
  Branches        352      352           
=========================================
  Hits           3424     3424           
  Misses          952      952           
  Partials        157      157

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 651e607...149ab2b. Read the comment docs.

@elharo
Copy link
Contributor Author

elharo commented Feb 15, 2019

@sduskis I don't have commit rights for this repo. You'll have to merge it. Thanks.

@igorbernstein2
Copy link
Contributor

This will keep diverging. Would it be possible to annotate the the README with x-version-update-start similar to google-cloud-java's README?

@sduskis sduskis requested a review from andreamlin February 20, 2019 20:49
@sduskis
Copy link
Contributor

sduskis commented Feb 20, 2019

@andreamlin, how can we keep the readme up to date?

@andreamlin
Copy link
Contributor

@sduskis #675

@andreamlin
Copy link
Contributor

I would like to merge in #676 to get the version at SNAPSHOT before merging this in.

@andreamlin andreamlin merged commit d41b922 into googleapis:master Feb 21, 2019
This was referenced Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants