Skip to content
This repository was archived by the owner on Sep 26, 2023. It is now read-only.

Conversation

@andreamlin
Copy link
Contributor

@andreamlin andreamlin commented Feb 13, 2019

To go along with google-cloud-java's dependency update: googleapis/google-cloud-java#4486

@andreamlin andreamlin requested a review from kolea2 February 13, 2019 19:11
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 13, 2019
@andreamlin andreamlin requested a review from sduskis February 13, 2019 19:12
@codecov
Copy link

codecov bot commented Feb 13, 2019

Codecov Report

Merging #666 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #666   +/-   ##
=========================================
  Coverage     75.94%   75.94%           
  Complexity     1014     1014           
=========================================
  Files           190      190           
  Lines          4452     4452           
  Branches        346      346           
=========================================
  Hits           3381     3381           
  Misses          915      915           
  Partials        156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d7458e...f1ef815. Read the comment docs.

@andreamlin
Copy link
Contributor Author

PTAL

@kolea2
Copy link
Contributor

kolea2 commented Feb 13, 2019

Thanks! Should I wait for this to be released before upgrading and merging mine?

@andreamlin andreamlin merged commit 8d0a872 into googleapis:master Feb 13, 2019
@andreamlin andreamlin deleted the update_common-protos branch February 13, 2019 23:01
This was referenced Feb 13, 2019
This was referenced Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants