Skip to content
This repository was archived by the owner on Jul 13, 2025. It is now read-only.

Conversation

@andreamlin
Copy link
Contributor

@andreamlin andreamlin requested a review from yihanzhen January 29, 2019 17:24
@andreamlin
Copy link
Contributor Author

PTAL

@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #2529 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2529      +/-   ##
============================================
- Coverage     86.72%   86.71%   -0.01%     
+ Complexity     5420     5419       -1     
============================================
  Files           461      461              
  Lines         21411    21411              
  Branches       2348     2348              
============================================
- Hits          18568    18567       -1     
  Misses         1998     1998              
- Partials        845      846       +1
Impacted Files Coverage Δ Complexity Δ
.../java/com/google/api/codegen/discovery/Schema.java 84.34% <0%> (-0.51%) 42% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1529cb3...668af0c. Read the comment docs.

@andreamlin andreamlin merged commit b0b9a22 into googleapis:master Jan 29, 2019
@andreamlin andreamlin deleted the compute_resource_name branch January 29, 2019 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants