feat: add "database" request param for Firestore::listen#776
Closed
feat: add "database" request param for Firestore::listen#776
Conversation
Collaborator
Author
|
This PR is an abomination and its author should be scorned from this repo forevermore |
bshaffer
deleted the
add-firestore-database-request-param-post-processor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses googleapis/google-cloud-php#8267
TODO:
Look at how to do this with the AST, instead of having PHP code in strings (which is scary)moved to heredoc instead - since the code is static there's no need to use an ASTPostProcessorTrait