Use application context to load ads - Android only #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luo86
approved these changes
Sep 23, 2021
...e_mobile_ads/android/src/main/java/io/flutter/plugins/googlemobileads/AdInstanceManager.java
Outdated
Show resolved
Hide resolved
envercc
pushed a commit
to esuljic/googleads-mobile-flutter
that referenced
this pull request
Nov 9, 2021
* upstream/master: (29 commits) Issue-404: Add App state event stream for app open ads (googleads#425) Issue 330: Android 12 crash (googleads#423) Remove unused dep. (googleads#424) Update inline adaptive example (googleads#419) Update anchored adaptive example (googleads#418) Fix ios warnings (googleads#416) Add support for getRequestConfiguration API (googleads#395) Add support for current orientation in AnchoredAdaptiveBannerAdSize (googleads#397) Set location and pub provided id (googleads#367) Adaptive inline banners (googleads#394) Fix issue 369 - setAppVolume (googleads#392) Add support for Fluid AdSize (AdManager Only) (googleads#375) Use application context to load ads - Android only (googleads#381) App open (googleads#360) Bump version to 0.13.4 (googleads#353) Refactor as per @luo86 review comments and add disableSDKCrashReporting, disableMediationInitialization and getVersionString APIs (googleads#345) Add support for Immersive Mode in Rewarded and Interstitial ads for Android (googleads#343) Add setAppMuted and setAppVolume implementations to MobileAds Flutter SDK (googleads#326) Fix typos and style issues (googleads#327) docs: Make it clear that the app must be registered to show live ads in the published app. (googleads#325) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a partial fix for #265. This allows you to load ads from a cached flutter engine in the add to app scenario. Note this does not allow for reusing the cached flutter engine after dismissing its flutter activity, since redisplaying platform views is currently not supported.
GoogleMobileAdsPlugininitialization fromonAttachedToActivitytoonAttachedToEngine.Related Issues
#265
*Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?