Skip to content

Conversation

@joshlf
Copy link
Member

@joshlf joshlf commented Jun 9, 2025

Previously, these types were gated by the stdarch_x86_avx512 nightly
Rust feature. As of 1.89.0, they are supported on stable.

Closes #2583


This PR is on branch simd-x86-avx12.

@joshlf joshlf requested a review from jswrenn June 9, 2025 15:36
@joshlf joshlf enabled auto-merge June 9, 2025 15:36
@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.14%. Comparing base (7b1260f) to head (d5bf1f1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2574   +/-   ##
=======================================
  Coverage   88.14%   88.14%           
=======================================
  Files          20       20           
  Lines        5450     5450           
=======================================
  Hits         4804     4804           
  Misses        646      646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jswrenn
Copy link
Collaborator

jswrenn commented Jun 10, 2025

I think we should punt on this until 1.89 is released, and in the meantime -A stable_features in our nightly CI runs. That will allow us to get the nightly CI roller working again.

@joshlf joshlf added the blocked-on-rust Blocked on a Rust feature landing or stabilizing label Jun 10, 2025
@joshlf
Copy link
Member Author

joshlf commented Jun 10, 2025

Blocked on #2583.

@joshlf joshlf force-pushed the I6907ba8f144bd90d917b85c9687443fc7cf19de2 branch 3 times, most recently from c59baac to ca6c178 Compare August 29, 2025 01:55
@joshlf joshlf added this pull request to the merge queue Aug 29, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 29, 2025
@usamoi
Copy link
Contributor

usamoi commented Sep 25, 2025

In these four types __m512bh, __m512, __m512d, and __m512i, only __m512bh was stabilized in Rust 1.89, while the other three were stabilized in Rust 1.72. Does it make sense to lower the required Rust version to 1.72?

See also: rust-lang/stdarch#1436

@joshlf joshlf force-pushed the I6907ba8f144bd90d917b85c9687443fc7cf19de2 branch 2 times, most recently from a31ff47 to b7d425f Compare November 21, 2025 15:37
@joshlf joshlf enabled auto-merge November 21, 2025 15:37
@joshlf
Copy link
Member Author

joshlf commented Nov 21, 2025

In these four types __m512bh, __m512, __m512d, and __m512i, only __m512bh was stabilized in Rust 1.89, while the other three were stabilized in Rust 1.72. Does it make sense to lower the required Rust version to 1.72?

See also: rust-lang/stdarch#1436

If this causes issues for someone, we can split out into more fine-grained features, but until then we'll stick with just this so we don't need to maintain more features.

@joshlf joshlf added this pull request to the merge queue Nov 21, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 21, 2025
Previously, these types were gated by the `stdarch_x86_avx512` nightly
Rust feature. As of 1.89.0, they are supported on stable.

Closes #2583

gherrit-pr-id: I6907ba8f144bd90d917b85c9687443fc7cf19de2
@joshlf joshlf force-pushed the I6907ba8f144bd90d917b85c9687443fc7cf19de2 branch from b7d425f to d5bf1f1 Compare November 21, 2025 17:06
@joshlf joshlf enabled auto-merge November 21, 2025 17:06
@joshlf joshlf added this pull request to the merge queue Nov 21, 2025
Merged via the queue into main with commit 7a698bd Nov 21, 2025
192 of 194 checks passed
@joshlf joshlf deleted the I6907ba8f144bd90d917b85c9687443fc7cf19de2 branch November 21, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-on-rust Blocked on a Rust feature landing or stabilizing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support x86 AVX-12 SIMD types without simd-nightly

4 participants