Skip to content

PoC for an ESLint rule to sort imports according to Site Kit's conventions. #12040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
techanvil wants to merge 18 commits into
base: develop
Choose a base branch
from
Open

PoC for an ESLint rule to sort imports according to Site Kit's conventions. #12040

techanvil wants to merge 18 commits into from

Conversation

@techanvil
Copy link
Collaborator

@techanvil techanvil commented Jan 7, 2026 •
edited
Loading

Summary

This is a PoC, do not merge as-is.

Addresses issue:

Relevant technical choices

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@techanvil techanvil force-pushed the infra/11668-eslint-sort-imports-poc branch from 2dff9c5 to a44581f Compare January 7, 2026 16:22
@github-actions
Copy link

github-actions bot commented Jan 7, 2026

Storybook is ready:

@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

Size Change: -562 B (-0.03%)

Total Size: 2.23 MB

ℹ️ View Unchanged
Filename Size Change
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 20 B 0 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB -11 B (-0.03%)
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B 0 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 20 B 0 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.88 kB -2 B (-0.03%)
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5.07 kB +2 B (+0.04%)
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.88 kB -1 B (-0.02%)
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5.07 kB +2 B (+0.04%)
./dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B 0 B
./dist/assets/blocks/sign-in-with-google/editor-styles.js 20 B 0 B
./dist/assets/blocks/sign-in-with-google/index.js 18.6 kB -1 B (-0.01%)
./dist/assets/css/googlesitekit-admin-css-********************.min.css 65.2 kB 0 B
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.7 kB 0 B
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B 0 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.6 kB 0 B
./dist/assets/js/146-********************.js 963 B 0 B
./dist/assets/js/201-********************.js 2.85 kB 0 B
./dist/assets/js/314-********************.js 100 kB 0 B
./dist/assets/js/315-********************.js 3.08 kB 0 B
./dist/assets/js/379-********************.js 3.7 kB 0 B
./dist/assets/js/590-********************.js 1.89 kB 0 B
./dist/assets/js/640-********************.js 2.36 kB 0 B
./dist/assets/js/909-********************.js 1.01 kB 0 B
./dist/assets/js/analytics-advanced-tracking-********************.js 475 B 0 B
./dist/assets/js/googlesitekit-activation-********************.js 24.6 kB -21 B (-0.09%)
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 56.4 kB -85 B (-0.15%)
./dist/assets/js/googlesitekit-adminbar-********************.js 34.7 kB -49 B (-0.14%)
./dist/assets/js/googlesitekit-api-********************.js 7.88 kB +2 B (+0.03%)
./dist/assets/js/googlesitekit-block-tracking-********************.js 5.48 kB -2 B (-0.04%)
./dist/assets/js/googlesitekit-components-********************.js 5.83 kB +17 B (+0.29%)
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.5 kB 0 B
./dist/assets/js/googlesitekit-data-********************.js 1.7 kB -1 B (-0.06%)
./dist/assets/js/googlesitekit-datastore-forms-********************.js 6.94 kB -10 B (-0.14%)
./dist/assets/js/googlesitekit-datastore-location-********************.js 1.51 kB -3 B (-0.2%)
./dist/assets/js/googlesitekit-datastore-site-********************.js 17.4 kB -3 B (-0.02%)
./dist/assets/js/googlesitekit-datastore-ui-********************.js 7.09 kB -7 B (-0.1%)
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.7 kB -22 B (-0.1%)
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 65.6 kB -47 B (-0.07%)
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.77 kB 0 B
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 745 B 0 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.77 kB 0 B
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.69 kB 0 B
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.72 kB 0 B
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.79 kB 0 B
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.14 kB 0 B
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.77 kB 0 B
./dist/assets/js/googlesitekit-i18n-********************.js 6.16 kB 0 B
./dist/assets/js/googlesitekit-key-metrics-setup-********************.js 50.1 kB -54 B (-0.11%)
./dist/assets/js/googlesitekit-main-dashboard-********************.js 137 kB -271 B (-0.2%)
./dist/assets/js/googlesitekit-metric-selection-********************.js 54.9 kB -2 B (0%)
./dist/assets/js/googlesitekit-modules-********************.js 19.8 kB -66 B (-0.33%)
./dist/assets/js/googlesitekit-modules-ads-********************.js 48.5 kB +58 B (+0.12%)
./dist/assets/js/googlesitekit-modules-adsense-********************.js 134 kB -21 B (-0.02%)
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 189 kB -713 B (-0.38%)
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.3 kB -43 B (-0.18%)
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 43.3 kB -378 B (-0.86%)
./dist/assets/js/googlesitekit-modules-search-console-********************.js 65.4 kB +105 B (+0.16%)
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 33.8 kB +142 B (+0.42%)
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30.3 kB +40 B (+0.13%)
./dist/assets/js/googlesitekit-notifications-********************.js 64.2 kB +900 B (+1.42%)
./dist/assets/js/googlesitekit-polyfills-********************.js 230 B 0 B
./dist/assets/js/googlesitekit-settings-********************.js 128 kB -129 B (-0.1%)
./dist/assets/js/googlesitekit-splash-********************.js 75.5 kB +207 B (+0.28%)
./dist/assets/js/googlesitekit-user-input-********************.js 48.4 kB +22 B (+0.05%)
./dist/assets/js/googlesitekit-vendor-********************.js 328 kB 0 B
./dist/assets/js/googlesitekit-widgets-********************.js 104 kB -74 B (-0.07%)
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60.8 kB -43 B (-0.07%)
./dist/assets/js/runtime-********************.js 1.92 kB 0 B

compressed-size-action

@github-actions
Copy link

github-actions bot commented Jan 7, 2026 •
edited
Loading

Build files for 3d3df80 are ready:

@techanvil techanvil force-pushed the infra/11668-eslint-sort-imports-poc branch from a44581f to 5239251 Compare January 7, 2026 16:49
@techanvil techanvil force-pushed the infra/11668-eslint-sort-imports-poc branch from 5239251 to aaaed61 Compare January 7, 2026 17:26
@techanvil techanvil changed the title Infra/11668 eslint sort imports poc PoC for a rule to sort imports according to Site Kit's conventions. Jan 7, 2026
@techanvil techanvil changed the title PoC for a rule to sort imports according to Site Kit's conventions. PoC for an ESLint rule to sort imports according to Site Kit's conventions. Jan 7, 2026
@techanvil techanvil mentioned this pull request Jan 7, 2026
Open
1 task
@techanvil techanvil force-pushed the infra/11668-eslint-sort-imports-poc branch from 3d3df80 to 07669ce Compare January 7, 2026 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@techanvil