-
Notifications
You must be signed in to change notification settings - Fork 330
Show the Welcome modal on the dashboard. #12036
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
| lastWidgetAnchor === ANCHOR_ID_MONETIZATION, | ||
| } ) } | ||
| /> | ||
| <OfflineNotification /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's out of scope, but I've removed this duplicate <OfflineNotification />, having spotted that it's rendered twice when it should only be rendered once.
|
Storybook is ready:
|
|
Size Change: +3.39 kB (+0.15%) Total Size: 2.23 MB
ℹ️ View Unchanged
|
|
Build files for a65dacd are ready:
|
|
|
||
| const showTooltip = useShowTooltip( tooltipSettings ); | ||
|
|
||
| const closeAndDismissModal = useCallback( async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I diverged slightly from the IB to ensure the modal is closed & items dismissed when clicking the Start tour button, while not showing the tooltip (the click handler can be extended when we implement the tour).
Summary
Addresses issue:
Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist