Enhancement/#11812 - Implement new designs for the TourTooltip component
#11934
+222
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust close icon size and conditionally render indicators based on feature availability.
…omponent. Adjust tooltip display based on setup flow refresh feature availability.
…ant. Enhance decorators for fetchMock setup to improve story switching functionality.
|
Storybook is ready:
|
|
Size Change: +2.89 kB (+0.13%) Total Size: 2.23 MB ℹ️ View Unchanged
|
|
Build files for 5888b8e are ready:
|
nfmohit
requested changes
Dec 27, 2025
Collaborator
nfmohit
left a comment
nfmohit
left a comment
There was a problem hiding this comment.
Thank you for your work on this, @hussain-t.
I've left a number of comments for your consideration. Please let me know if you have any questions or concerns. Thanks!
assets/sass/components/tour-tooltip/_googlesitekit-tour-tooltip.scss
Outdated
Show resolved
Hide resolved
assets/sass/components/tour-tooltip/_googlesitekit-tour-tooltip.scss
Outdated
Show resolved
Hide resolved
…tiary style based on setupFlowRefreshEnabled state.
…ng adjustments to title and body properties, and add conditional styles for legacy design.
… for title and content based on setupFlowRefreshEnabled state.
…um, removing conditional logic based on setupFlowRefreshEnabled state.
…sting button margin for improved layout.
…ing max-width and padding for improved layout and specificity.
Collaborator
Author
Thanks for your kind review, @nfmohit! I've addressed most of the feedback. Please take another look. |
nfmohit
requested changes
Jan 5, 2026
Collaborator
nfmohit
left a comment
nfmohit
left a comment
There was a problem hiding this comment.
Thank you for addressing my comments, @hussain-t!
I've left a few additional comments for your consideration. Please let me know if you have any questions or concerns. Thanks!
| top: $grid-gap-phone; | ||
| } | ||
|
|
||
| .googlesitekit-tooltip-button { |
Collaborator
There was a problem hiding this comment.
We also need to remove the box shadow as it doesn't appear in Figma.
Figma:
Implementation:
| top: $grid-gap-phone; | ||
| } | ||
|
|
||
| .googlesitekit-tooltip-button { |
Collaborator
There was a problem hiding this comment.
It looks like we're also missing hover and focus styles for both the primary and tertiary buttons.
We should clarify them with Sigal (if necessary) and add them.
|
|
||
| .googlesitekit-tooltip-button { | ||
| border-radius: $br-lg; | ||
| line-height: 20px; |
Collaborator
There was a problem hiding this comment.
Let's change this to $lh-label-md.
Suggested change
| line-height: 20px; | |
| line-height: $lh-label-md; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
TourTooltipcomponent to reflect the new design. #11812Relevant technical choices
PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist