docs: update SQL Macro usecase #3289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In PR#3276, we found a MACRO usecase which wasn't listed before. Therefore adding this usecase and explainations of it in the doc. Basically, it would be ok to use MACRO for a constant if it would be referenced massive times and it would be bad to use FUNCTION for it which will bring massive performance overhead since SQL FUNCTION can't do inlining.
LalitMaganti
approved these changes
Oct 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR#3276, we found a MACRO usecase which wasn't listed before. Therefore adding this usecase and explainations of it in the doc.
Basically, it would be ok to use
MACROfor a constant if it would be referenced massive times and it would be bad to useFUNCTIONfor it which will bring massive performance overhead since SQLFUNCTIONcan't do inlining.Welcome to Perfetto!
Make sure your PR has a bug/issue attached or has at least
a clear description of the problem you are trying to fix.
For more details please see
https://perfetto.dev/docs/contributing/getting-started