Skip to content

Conversation

@G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Nov 5, 2025

Per google/osv-scalibr#1511 and https://blog.deps.dev/rubygems/ we can now do license scanning for RubyGems

@G-Rath G-Rath requested review from another-rex and cuixq November 5, 2025 01:16
@G-Rath G-Rath force-pushed the support-ruby-for-licenses branch from 187b537 to a2025a1 Compare November 5, 2025 01:27
@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.05%. Comparing base (f90634b) to head (f59d3c4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2321   +/-   ##
=======================================
  Coverage   68.05%   68.05%           
=======================================
  Files         172      172           
  Lines       12841    12841           
=======================================
  Hits         8739     8739           
  Misses       3433     3433           
  Partials      669      669           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuixq cuixq requested a review from Ly-Joey November 5, 2025 02:05
Copy link
Contributor

@Ly-Joey Ly-Joey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to do this to the license enricher in osv-scalibr too

@G-Rath
Copy link
Collaborator Author

G-Rath commented Nov 5, 2025

yup I can do that now, I just wasn't sure if you were doing that as I've had that happen a couple of times on scalibr 😅

@Ly-Joey
Copy link
Contributor

Ly-Joey commented Nov 10, 2025

Thank you so much!

@G-Rath G-Rath force-pushed the support-ruby-for-licenses branch from a2025a1 to f59d3c4 Compare November 10, 2025 21:32
@G-Rath G-Rath merged commit 9810ee3 into google:main Nov 10, 2025
16 checks passed
@G-Rath G-Rath deleted the support-ruby-for-licenses branch November 10, 2025 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants