Skip to content

feat: support scanning rpm databases #2234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support scanning rpm databases #2234

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
102 changes: 102 additions & 0 deletions cmd/osv-scanner/scan/image/__snapshots__/command_test.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,6 +636,108 @@ You can also view the full vulnerability list in your terminal with: `osv-scanne

---

[TestCommand_OCIImage/rockylinux_empty_image - 1]
Scanning local image tarball "./testdata/test-rockylinux.tar"

Container Scanning Result (Rocky Linux 9.2 (Blue Onyx)):
Total 13 packages affected by 32 known vulnerabilities (0 Critical, 15 High, 3 Medium, 0 Low, 14 Unknown) from 2 ecosystems.
4 vulnerabilities can be fixed.


PyPI
+--------------------------------------------------------------------------------------------------+
| Source:artifact:/usr/share/python3-wheels/pip-21.2.3-py3-none-any.whl |
+---------+-------------------+---------------+------------+------------------+--------------------+
| PACKAGE | INSTALLED VERSION | FIX AVAILABLE | VULN COUNT | INTRODUCED LAYER | IN BASE IMAGE |
+---------+-------------------+---------------+------------+------------------+--------------------+
| pip | 21.2.3 | Fix Available | 1 | # 0 Layer | library/rockylinux |
+---------+-------------------+---------------+------------+------------------+--------------------+
+-----------------------------------------------------------------------------------------------------+
| Source:artifact:/usr/share/python3-wheels/setuptools-53.0.0-py3-none-any.whl |
+------------+-------------------+---------------+------------+------------------+--------------------+
| PACKAGE | INSTALLED VERSION | FIX AVAILABLE | VULN COUNT | INTRODUCED LAYER | IN BASE IMAGE |
+------------+-------------------+---------------+------------+------------------+--------------------+
| setuptools | 53.0.0 | Fix Available | 3 | # 0 Layer | library/rockylinux |
+------------+-------------------+---------------+------------+------------------+--------------------+
Rocky Linux
+--------------------------------------------------------------------------------------------------------------------------------------+
| Source:os:/var/lib/rpm/rpmdb.sqlite |
+----------------+-------------------+------------------+------------+-------------------------+------------------+--------------------+
| SOURCE PACKAGE | INSTALLED VERSION | FIX AVAILABLE | VULN COUNT | BINARY PACKAGES (COUNT) | INTRODUCED LAYER | IN BASE IMAGE |
+----------------+-------------------+------------------+------------+-------------------------+------------------+--------------------+
| expat | 2.5.0-1.el9 | No fix available | 2 | expat | # 0 Layer | library/rockylinux |
| glib2 | 2.68.4-6.el9 | No fix available | 1 | glib2 | # 0 Layer | library/rockylinux |
| glibc | 2.34-60.el9 | No fix available | 2 | glibc | # 0 Layer | library/rockylinux |
| gnutls | 3.7.6-20.el9_2 | No fix available | 1 | gnutls | # 0 Layer | library/rockylinux |
| less | 590-1.el9_0 | No fix available | 3 | less | # 0 Layer | library/rockylinux |
| libeconf | 0.4.1-2.el9 | No fix available | 1 | libeconf | # 0 Layer | library/rockylinux |
| libgcrypt | 1.10.0-10.el9_2 | No fix available | 1 | libgcrypt | # 0 Layer | library/rockylinux |
| libxml2 | 2.9.13-3.el9_1 | No fix available | 2 | libxml2 | # 0 Layer | library/rockylinux |
| openssl | 3.0.7-6.el9_2 | No fix available | 12 | openssl | # 0 Layer | library/rockylinux |
| pam | 1.5.1-14.el9 | No fix available | 1 | pam | # 0 Layer | library/rockylinux |
| tar | 1.34-6.el9_1 | No fix available | 2 | tar | # 0 Layer | library/rockylinux |
+----------------+-------------------+------------------+------------+-------------------------+------------------+--------------------+

For the most comprehensive scan results, we recommend using the HTML output: `osv-scanner scan image --serve <image_name>`.
You can also view the full vulnerability list in your terminal with: `osv-scanner scan image --format vertical <image_name>`.

---

[TestCommand_OCIImage/rockylinux_empty_image - 2]

---

[TestCommand_OCIImage/rockylinux_empty_image_all_vulns - 1]
Scanning local image tarball "./testdata/test-rockylinux.tar"

Container Scanning Result (Rocky Linux 9.2 (Blue Onyx)):
Total 13 packages affected by 32 known vulnerabilities (0 Critical, 15 High, 3 Medium, 0 Low, 14 Unknown) from 2 ecosystems.
4 vulnerabilities can be fixed.


PyPI
+--------------------------------------------------------------------------------------------------+
| Source:artifact:/usr/share/python3-wheels/pip-21.2.3-py3-none-any.whl |
+---------+-------------------+---------------+------------+------------------+--------------------+
| PACKAGE | INSTALLED VERSION | FIX AVAILABLE | VULN COUNT | INTRODUCED LAYER | IN BASE IMAGE |
+---------+-------------------+---------------+------------+------------------+--------------------+
| pip | 21.2.3 | Fix Available | 1 | # 0 Layer | library/rockylinux |
+---------+-------------------+---------------+------------+------------------+--------------------+
+-----------------------------------------------------------------------------------------------------+
| Source:artifact:/usr/share/python3-wheels/setuptools-53.0.0-py3-none-any.whl |
+------------+-------------------+---------------+------------+------------------+--------------------+
| PACKAGE | INSTALLED VERSION | FIX AVAILABLE | VULN COUNT | INTRODUCED LAYER | IN BASE IMAGE |
+------------+-------------------+---------------+------------+------------------+--------------------+
| setuptools | 53.0.0 | Fix Available | 3 | # 0 Layer | library/rockylinux |
+------------+-------------------+---------------+------------+------------------+--------------------+
Rocky Linux
+--------------------------------------------------------------------------------------------------------------------------------------+
| Source:os:/var/lib/rpm/rpmdb.sqlite |
+----------------+-------------------+------------------+------------+-------------------------+------------------+--------------------+
| SOURCE PACKAGE | INSTALLED VERSION | FIX AVAILABLE | VULN COUNT | BINARY PACKAGES (COUNT) | INTRODUCED LAYER | IN BASE IMAGE |
+----------------+-------------------+------------------+------------+-------------------------+------------------+--------------------+
| expat | 2.5.0-1.el9 | No fix available | 2 | expat | # 0 Layer | library/rockylinux |
| glib2 | 2.68.4-6.el9 | No fix available | 1 | glib2 | # 0 Layer | library/rockylinux |
| glibc | 2.34-60.el9 | No fix available | 2 | glibc | # 0 Layer | library/rockylinux |
| gnutls | 3.7.6-20.el9_2 | No fix available | 1 | gnutls | # 0 Layer | library/rockylinux |
| less | 590-1.el9_0 | No fix available | 3 | less | # 0 Layer | library/rockylinux |
| libeconf | 0.4.1-2.el9 | No fix available | 1 | libeconf | # 0 Layer | library/rockylinux |
| libgcrypt | 1.10.0-10.el9_2 | No fix available | 1 | libgcrypt | # 0 Layer | library/rockylinux |
| libxml2 | 2.9.13-3.el9_1 | No fix available | 2 | libxml2 | # 0 Layer | library/rockylinux |
| openssl | 3.0.7-6.el9_2 | No fix available | 12 | openssl | # 0 Layer | library/rockylinux |
| pam | 1.5.1-14.el9 | No fix available | 1 | pam | # 0 Layer | library/rockylinux |
| tar | 1.34-6.el9_1 | No fix available | 2 | tar | # 0 Layer | library/rockylinux |
+----------------+-------------------+------------------+------------+-------------------------+------------------+--------------------+

For the most comprehensive scan results, we recommend using the HTML output: `osv-scanner scan image --serve <image_name>`.
You can also view the full vulnerability list in your terminal with: `osv-scanner scan image --format vertical <image_name>`.

---

[TestCommand_OCIImage/rockylinux_empty_image_all_vulns - 2]

---

[TestCommand_OCIImage/scanning_image_with_go_binary - 1]
Scanning local image tarball "./testdata/test-package-tracing.tar"

Expand Down
10 changes: 10 additions & 0 deletions cmd/osv-scanner/scan/image/command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,6 +212,16 @@ func TestCommand_OCIImage(t *testing.T) {
"./testdata/test-ubuntu-20-04.tar"},
Exit: 0,
},
{
Name: "rockylinux_empty_image",
Args: []string{"", "image", "--archive", "./testdata/test-rockylinux.tar"},
Exit: 1,
},
{
Name: "rockylinux_empty_image_all_vulns",
Args: []string{"", "image", "--all-vulns", "--archive", "./testdata/test-rockylinux.tar"},
Exit: 1,
},
{
Name: "Scanning python image with some packages",
Args: []string{"", "image", "--archive", "./testdata/test-python-full.tar"},
Expand Down
1 change: 1 addition & 0 deletions cmd/osv-scanner/scan/image/testdata/test-rockylinux.Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
FROM rockylinux:9.2.20230513@sha256:b07e21a7bbcecbae55b9153317d333d4d50808bf5dc0859db0180b6fbd7afb3d
1 change: 1 addition & 0 deletions internal/scalibrplugin/__snapshots__/resolve_test.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ java/archive
javascript/nodemodules
os/apk
os/dpkg
os/rpm
python/wheelegg
rust/cargoauditable
---
Expand Down
3 changes: 3 additions & 0 deletions internal/scalibrplugin/presets.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@ import (
extractors "github.com/google/osv-scalibr/extractor/filesystem/list"
"github.com/google/osv-scalibr/extractor/filesystem/os/apk"
"github.com/google/osv-scalibr/extractor/filesystem/os/dpkg"
"github.com/google/osv-scalibr/extractor/filesystem/os/rpm"
"github.com/google/osv-scalibr/extractor/filesystem/sbom/cdx"
"github.com/google/osv-scalibr/extractor/filesystem/sbom/spdx"
"github.com/google/osv-scanner/v2/internal/datasource"
Expand Down Expand Up @@ -136,6 +137,8 @@ var ExtractorPresets = map[string]extractors.InitMap{
apk.Name: {apk.NewDefault},
// Debian
dpkg.Name: {dpkg.NewDefault},
// RedHat
rpm.Name: {rpm.NewDefault},
},
}

Expand Down
5 changes: 5 additions & 0 deletions internal/scalibrplugin/resolve_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import (
chromeextensions "github.com/google/osv-scalibr/extractor/filesystem/misc/chrome/extensions"
"github.com/google/osv-scalibr/extractor/filesystem/os/apk"
"github.com/google/osv-scalibr/extractor/filesystem/os/dpkg"
"github.com/google/osv-scalibr/extractor/filesystem/os/rpm"
"github.com/google/osv-scalibr/extractor/filesystem/sbom/cdx"
"github.com/google/osv-scalibr/extractor/filesystem/sbom/spdx"
"github.com/google/osv-scanner/v2/internal/scalibrextract/filesystem/vendored"
Expand Down Expand Up @@ -399,6 +400,7 @@ func TestResolve_Extractors(t *testing.T) {
dpkg.Name,
gobinary.Name,
nodemodules.Name,
rpm.Name,
wheelegg.Name,
},
},
Expand All @@ -416,6 +418,7 @@ func TestResolve_Extractors(t *testing.T) {
dpkg.Name,
gobinary.Name,
nodemodules.Name,
rpm.Name,
wheelegg.Name,
},
},
Expand All @@ -439,6 +442,7 @@ func TestResolve_Extractors(t *testing.T) {
dpkg.Name,
gobinary.Name,
nodemodules.Name,
rpm.Name,
},
},
//
Expand All @@ -458,6 +462,7 @@ func TestResolve_Extractors(t *testing.T) {
gobinary.Name,
nodemodules.Name,
vendored.Name,
rpm.Name,
wheelegg.Name,
},
},
Expand Down
Loading