feat: make various experimental fields as stable#1963
Merged
cuixq merged 1 commit intogoogle:mainfrom Jun 19, 2025
Merged
Conversation
G-Rath
commented
Jun 16, 2025
| LocalDBPath: cmd.String("local-db-path"), | ||
| DownloadDatabases: cmd.Bool("download-offline-databases"), | ||
| CompareOffline: cmd.Bool("offline-vulnerabilities"), | ||
| func GetCommonScannerActions(cmd *cli.Command, scanLicensesAllowlist []string) osvscanner.ScannerActions { |
Collaborator
Author
There was a problem hiding this comment.
note I think we could also handle getting the scanLicensesAllowlist here, but I've left that for another PR because it would involve moving some other code around in order to support returning an error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1963 +/- ##
=======================================
Coverage 65.77% 65.77%
=======================================
Files 167 167
Lines 16071 16072 +1
=======================================
+ Hits 10571 10572 +1
Misses 4841 4841
Partials 659 659 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
another-rex
approved these changes
Jun 18, 2025
cuixq
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These fields were marked as stable as part of the v2 release but we forgot to move the actual struct fields out of the experimental struct, which this does.
Technically this isn't breaking because we declare anything in the experimental struct as not being covered by semver 😅