Skip to content

feat: make various experimental fields as stable#1963

Merged
cuixq merged 1 commit intogoogle:mainfrom
ackama:make-not-experimental
Jun 19, 2025
Merged

feat: make various experimental fields as stable#1963
cuixq merged 1 commit intogoogle:mainfrom
ackama:make-not-experimental

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Jun 16, 2025

These fields were marked as stable as part of the v2 release but we forgot to move the actual struct fields out of the experimental struct, which this does.

Technically this isn't breaking because we declare anything in the experimental struct as not being covered by semver 😅

@G-Rath G-Rath requested review from another-rex, cuixq and hogo6002 June 16, 2025 02:58
LocalDBPath: cmd.String("local-db-path"),
DownloadDatabases: cmd.Bool("download-offline-databases"),
CompareOffline: cmd.Bool("offline-vulnerabilities"),
func GetCommonScannerActions(cmd *cli.Command, scanLicensesAllowlist []string) osvscanner.ScannerActions {
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note I think we could also handle getting the scanLicensesAllowlist here, but I've left that for another PR because it would involve moving some other code around in order to support returning an error

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jun 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.77%. Comparing base (4f77b30) to head (956e85c).
⚠️ Report is 537 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1963   +/-   ##
=======================================
  Coverage   65.77%   65.77%           
=======================================
  Files         167      167           
  Lines       16071    16072    +1     
=======================================
+ Hits        10571    10572    +1     
  Misses       4841     4841           
  Partials      659      659           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cuixq cuixq merged commit 3b7bd34 into google:main Jun 19, 2025
17 checks passed
@cuixq cuixq deleted the make-not-experimental branch June 19, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants