Save crash reproducer found in experiments. #172
Conversation
|
@oliverchang Please correct me if the sample |
oliverchang
left a comment
oliverchang
left a comment
There was a problem hiding this comment.
benchmark.json looks great, thanks!
report/templates/benchmark.json
Outdated
| "benchmark": "{{ benchmark.signature }}", | ||
| "sample": "{{ sample.id }}", | ||
| "status": "{{ sample.status }}", | ||
| "Compiles": "{{ sample.compiles }}", |
There was a problem hiding this comment.
nit: lower case compiles?
report/templates/benchmark.json
Outdated
| "coverage": "{{ sample.coverage | percent }}", | ||
| "coverage_diff": "{{ sample.result.line_coverage_diff }}", | ||
| "coverage_report": "{{ sample.result.coverage_report_path }}", | ||
| "stacktrace": "{{ sample.result.stacktrace_link }}", |
There was a problem hiding this comment.
maybe just output to generalize this more. This would include both the libFuzzer output + stacktrace (if any).
There was a problem hiding this comment.
I see. BTW, I am adding a bit more code to google/oss-fuzz#11700 to upload the stacktrace too.
Sorry about the frequent review requests an changes.
There was a problem hiding this comment.
Do we need this? I assume the stacktrace/output is already there somewhere when we run web.py ?
There was a problem hiding this comment.
Would it be better to have a separate item to link to the libFuzzer output?
e.g.,
"output": "{{ sample.result.output_link }}",
This info is already available and needs not to be uploaded to the new reproducer bucket directory.
|
JOB: https://pantheon.corp.google.com/kubernetes/job/us-central1-c/llm-experiment/default/ofg-pr-172-dg |
|
Changes since the last exp:
JOB: https://pantheon.corp.google.com/kubernetes/job/us-central1-c/llm-experiment/default/ofg-pr-172-dg |
…nt.py` (#11713) Related: google/oss-fuzz-gen#172, #11700. This simplifies the link generation in benchmark `JSON`. Previously, the binary directory name matches the binary name, now it is always called `target_binary/`.
|
Pretty sure this should work: |
2 participants
Fixes #156.
Related: google/oss-fuzz#11700.
Save GS bucket links to the reproducer and other statuses into a JSON file.