Fix bz2.dll install path for windows-cpp archive #4685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Windows, bz2.dll is incorrectly placed in install/lib, instead of install/bin. This causes "missing DLL error at runtime" kind of issues for binaries linking dynamically to OR-Tools 9.13 through CMake.
This issue was reported in 2022 in bzip2's official repository, but it was ignored by bzip2's maintainers.
bzip2 was introduced as a dependency of OR-Tools from v9.13, which is why we have this problem right now.
Example of this or-tools_x64_VisualStudio2022_cpp_v9.13.4784.zip