Rendering fix for degenerate UVs #1078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elalish
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that was reported through a different channel. I had actually noticed before getting occasional triangles that would either be completely black or covered with random black noise, and traced it down to triangles with degenerate UV coordinates (different vertices with the same UV coords). It will only manifest if tangent vectors are not supplied.
I had assumed at first this was a problem with the authoring software, but it turns out this happens pretty often during compression by quantization, as happens with DRACO, etc. The problem is just NaNs creeping into the normal vector computation, so I've fixed that here.