added try catch in computeifpresent to preserve old value incase of e… #5896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ben-manes
reviewed
Jan 25, 2022
| } | ||
| return function.apply(k, oldValue); | ||
| }catch (Throwable e){ | ||
| this.put(k,oldValue); |
Contributor
There was a problem hiding this comment.
This is a bit sketchy, e.g. ConcurrentHashMap does not allow writes within a computation. I think it would be better to handle this within the compute method, even if a more complex method to understand.
Contributor
|
Ideally fix the formatting to Google's style guide, but maybe if merged that person will do it. You might want to run Caffeine's test suite against your new dependency. You can use jitpack.io or a file dependency, and update the non-atomic computes from |
Member
|
We ended up going a different direction in #7980. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added try catch in computeifpresent to preserve old value incase of errors
Issue 5438 - #5438