Skip to content

Init lockFreeBitArray with length to reduce memory #5799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Init lockFreeBitArray with length to reduce memory #5799

wants to merge 3 commits into from

Conversation

@karthikbhat13
Copy link
Contributor

@karthikbhat13 karthikbhat13 commented Dec 1, 2021

Fixes: #5770

Initializing LockFreeBitArray with bit array would clone (while creating AtomicLongarray) the array passed in the background doubling the memory consumed. Previous logic also used a local variable that was holding the data that would be cloned again later.

Fix - Initialize the LockFreeBitArray with length initially and populate the array with bits directly from the dataStream.

@google-cla google-cla bot added the cla: yes label Dec 1, 2021
@cpovirk cpovirk added P2 package=hash type=enhancement Make an existing feature better labels Dec 13, 2021
@copybara-service copybara-service bot mentioned this pull request Jan 11, 2022
Closed
copybara-service bot pushed a commit that referenced this pull request Jan 11, 2022
@netdpb
Init LockFreeBitArray with length to reduce memory when deserializi…
214ded9 
…ng `BloomFilter`.

Closes #5799.
Fixes #5770.

RELNOTES=n/a
PiperOrigin-RevId: 414744518
@copybara-service copybara-service bot mentioned this pull request Jan 13, 2022
Closed
copybara-service bot pushed a commit that referenced this pull request Jan 13, 2022
@netdpb
Init LockFreeBitArray with length to reduce memory when deserializi…
d48a163 
…ng `BloomFilter`.

Second try, setting the `bitCount` property correctly.

Closes #5799.
Fixes #5770.

RELNOTES=n/a
PiperOrigin-RevId: 421301343
copybara-service bot pushed a commit that referenced this pull request Jan 13, 2022
@karthikbhat13
Init LockFreeBitArray with length to reduce memory when deserializi…
a4fabc0 
…ng `BloomFilter`.

Second try, setting the `bitCount` property correctly.

Closes #5799.
Fixes #5770.

RELNOTES=n/a
PiperOrigin-RevId: 421580967
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@netdpb netdpb

Labels

cla: yes P2 package=hash type=enhancement Make an existing feature better

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Halve memory used by BloomFilter.java : readFrom()

3 participants

@karthikbhat13 @cpovirk @netdpb