Skip to content

Conversation

@andreia-ferreira
Copy link
Collaborator

@andreia-ferreira andreia-ferreira commented Dec 15, 2025

Towards #3365

In order to update the current E2E test the code needs to take into account Compose elements that were added in the meantime. However, adding the dependency and the composeTestRule in the e2eTest module would cause a NoSuchMethodError crash.

This PR fixes that by replacing androidx.fragment:fragment-testing with fragment-testing-manifest. This ensures the tests continue to have the necessary components while avoiding dependency conflicts and runtime crashes.

Additionally a couple of improvements were done:

  • Use BOM for compose, coroutines, and serialization so that all related libraries are aligned to compatible versions, reducing the risk of dependency conflicts and simplifying version management
  • Remove unused dependencies

In order to make sure that no issues were introduced by this, a general sanity check of the app was performed.

@shobhitagarwal1612 PTAL?

@auto-assign auto-assign bot requested a review from scolsen December 15, 2025 18:48
@andreia-ferreira andreia-ferreira requested review from shobhitagarwal1612 and removed request for scolsen December 15, 2025 18:55
@codecov
Copy link

codecov bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.26%. Comparing base (8d9861d) to head (6c67d18).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3406   +/-   ##
=========================================
  Coverage     69.26%   69.26%           
  Complexity     1589     1589           
=========================================
  Files           317      317           
  Lines          8491     8491           
  Branches        938      938           
=========================================
  Hits           5881     5881           
  Misses         2038     2038           
  Partials        572      572           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shobhitagarwal1612
Copy link
Member

Can you please update the description to specify if any regression / sanity testing was performed?

@andreia-ferreira andreia-ferreira merged commit 84dc156 into master Dec 16, 2025
7 checks passed
@andreia-ferreira andreia-ferreira deleted the andreia/3365/optimize-dependencies branch December 16, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants