Fix RegEx for xpath leaf-list keys which include a "-" character.#240
Merged
mike-albano merged 1 commit intomasterfrom Sep 17, 2020
Merged
Fix RegEx for xpath leaf-list keys which include a "-" character.#240mike-albano merged 1 commit intomasterfrom
mike-albano merged 1 commit intomasterfrom
Conversation
For example: /bgp/neighbors/neighbor[neighbor-address=30.1.1.1]/config/neighbor-address
Closed
Verma-Anukul
added a commit
to Verma-Anukul/sonic-buildimage
that referenced
this pull request
Jan 27, 2026
Signed-off-by: Verma-Anukul <[email protected]>
8 tasks
Verma-Anukul
added a commit
to Verma-Anukul/sonic-buildimage
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Verma-Anukul <[email protected]>
yxieca
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 20, 2026
What is the motivation for this PR? When running pygnmi GET requests with xpaths where the keyname contains "-", pygnmi returns errors (xpath parse error and syntax warnings). This blocks openconfig sonic-mgmt tests. How did you do it? Ported the gnxi upstream patch (google/gnxi#240) to sonic-buildimage and fixed the python syntax issues in py_gnmicli.py. How did you verify/test it? Tested patch application, ran pygnmi with key-name containing "-", and ran sonic-mgmt gnmi tests. Signed-off-by: Verma-Anukul <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
/bgp/neighbors/neighbor[neighbor-address=30.1.1.1]/config/neighbor-address