Skip to content

Conversation

@zchee
Copy link
Contributor

@zchee zchee commented Sep 26, 2021

Fix module name to github.com/google/gnostic, and support goimports local prefix.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 26, 2021
@zchee
Copy link
Contributor Author

zchee commented Sep 26, 2021

/cc @timburks

$ goimports -w -local github.com/google/gnostic $(find . -type f -name '*.go' -not -iwholename '*vendor*' -not -name '*.pb.go')

Signed-off-by: Koichi Shiraishi <[email protected]>
Copy link
Contributor

@timburks timburks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zchee Looks great! Thank you very much!

@brycefisher
Copy link

Sadly, this change has broken my go install .... I think this change is actually a breaking change, right? Since the name of the package is different, you cannot simply rollforward. So, this should be version v0.6.0 not v0.5.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants