Skip to content
This repository was archived by the owner on Oct 13, 2025. It is now read-only.

add support for github actions #364

Merged
jamesderlin merged 2 commits into from
May 24, 2022
Merged

add support for github actions #364

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d11557
add support for github actions
devoncarew May 5, 2022
8e2f46f
Update build.yaml
devoncarew May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
name: Flutter

on:
schedule:
# “At 00:00 (UTC) on Sunday.”
- cron: '0 0 * * 0'
pull_request:
push:
branches:
- master

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: subosito/flutter-action@v2.4
Copy link
Contributor Author

@devoncarew devoncarew May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, maybe this should have been v2.4.0?

with:
channel: 'stable'
Copy link
Contributor

@jamesderlin jamesderlin May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this mean that it's going to test against Flutter's stable channel?

I think the Git repository should be testing against the master channel since Google internally consumes these packages via Git + copybara and tries to stay current with Flutter's master branch.

Copy link
Contributor Author

@devoncarew devoncarew May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do get this PR landed, we can revisit it to run against master and stable - a matrix of jobs for [packages] x [stable, master].

Copy link
Contributor

@dnfield dnfield May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

visibility_detector will not pass on stable after #367 - it's intentionally using new API that was created for the refactor.

- run: flutter --version
- run: tool/validate.sh
2 changes: 1 addition & 1 deletion tool/travis.sh → tool/validate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ echo "PASSED"
echo

# Make sure we pass the analyzer
echo "Checking dartanalyzer..."
echo "Checking flutter analyze..."
for package_pubspec in packages/**/pubspec.yaml ; do
package_dir=$(dirname "${package_pubspec}")
echo "${package_dir}"
Expand Down