Clear diagnostics after testing in CompilationTestHelper #1313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the report. These instances aren't really intended to be use-used, but I agree we should either support re-use or else detect it and report an error if If you have tests where it would be helpful to support the former, can you expand on your use-case? |
kluever
pushed a commit
that referenced
this pull request
May 14, 2020
…ctoringTestHelper instances See e.g. #1313 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311470656
kluever
pushed a commit
that referenced
this pull request
May 14, 2020
…ctoringTestHelper instances See e.g. #1313 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=311470656
Collaborator
|
Tentatively resolving with 8bfc2f8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
CompilationTestHelperis reused after a positive test case, it is possible for a false positive test case to pass. This is because we do not clear theDiagnosticTestHelperafter callingdoTest. So a subsequent false positive test will pass if the diagnostics is that same as the previous positive test case.