Add Korean translation #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
jiyongp
commented
Jan 30, 2023
jiyongp
commented
- add ko.po
- translate ko(~23.01.19)
- change speaker-note ko
- change id
- translate ko(~23.01.20)
- ~day3 keynote
- draft done to f3446a9
- add @jiyongp comments of upstream PR Initial Korean commit #276.
- sync & apply review comments(upstream)
- After 10000 line apply review comments(upstream)
- chgange build.yml
- Fix the inconsistent newline character problem for the KO translation
sync 23.01.20
sync upstream
sync mainstream 585509b
If a msgid does not end with the newline character, so should the msgstr. Test: msgfmt --statistics -o /dev/null po/ko.po No error, but shows `1085 translated messages, 675 untranslated messages.`
jiyongp
changed the title
Collaborator
Author
This was referenced Jan 30, 2023
Closed
Merged
NoahDragon
pushed a commit
to wnghl/comprehensive-rust
that referenced
this pull request
Jul 19, 2023
* add ko.po * translate ko(~23.01.19) * change speaker-note ko * change id * translate ko(~23.01.20) * ~day3 keynote * draft done to f3446a9 * add @jiyongp comments of upstream PR google#276. * sync & apply review comments(upstream) sync 585509b * After 10000 line apply review comments(upstream) * chgange build.yml * Fix the inconsistent newline character problem for the KO translation If a msgid does not end with the newline character, so should the msgstr. Test: msgfmt --statistics -o /dev/null po/ko.po No error, but shows `1085 translated messages, 675 untranslated messages.` --------- Co-authored-by: Evan kim(cli) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.