Fix C++17 mode compilation with Apple clang#721
Merged
EricWF merged 1 commit intogoogle:masterfrom Nov 22, 2018
traceon:fix-cpp17-compilation
Merged
Fix C++17 mode compilation with Apple clang#721EricWF merged 1 commit intogoogle:masterfrom traceon:fix-cpp17-compilation
EricWF merged 1 commit intogoogle:masterfrom
traceon:fix-cpp17-compilation
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Contributor
Author
|
I signed it! |
|
CLAs look good, thanks! |
Contributor
|
LGTM, but I'll wait for the bots to cycle before merging this. |
|
✅ Build benchmark 1567 completed (commit de980c4f19 by @traceon) |
Member
|
thank you! |
EricWF
pushed a commit
to efcs/benchmark
that referenced
this pull request
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following compilation error: