Make 'complexity reports' cache per-family, not global#1166
Merged
LebedevRI merged 1 commit intogoogle:mainfrom Jun 3, 2021
Merged
Make 'complexity reports' cache per-family, not global#1166LebedevRI merged 1 commit intogoogle:mainfrom
LebedevRI merged 1 commit intogoogle:mainfrom
Conversation
LebedevRI
commented
Jun 3, 2021
dmah42
reviewed
Jun 3, 2021
dmah42
reviewed
Jun 3, 2021
While the current variant works, it assumes that all the instances of a single family will be run together, with nothing inbetween them. Naturally, that won't work once the runs may be interleaved.
LebedevRI
force-pushed
the
per-family-complexity-reports
branch
from
e8e2471 to
89adc8e
Compare
Collaborator
Author
|
@dominichamon does this look good to you now? |
dmah42
approved these changes
Jun 3, 2021
vincenzopalazzo
pushed a commit
to vincenzopalazzo/benchmark
that referenced
this pull request
Feb 8, 2022
While the current variant works, it assumes that all the instances of a single family will be run together, with nothing inbetween them. Naturally, that won't work once the runs may be interleaved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While the current variant works, it assumes that all the instances of
a single family will be run together, with nothing inbetween them.
Naturally, that won't work once the runs may be interleaved.