-
Notifications
You must be signed in to change notification settings - Fork 6
docs(readme): enhance readme with more filler text #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request. It looks like this is your first contribution to a Google open source project, or you're using an email address we haven't seen before. Before proceeding, you'll need to sign a Contributor License Agreement (CLA) at https://cla.developers.google.com/. Once you've done that, please reply here to let us know. If you signed the CLA as a corporation, please let us know the company's name. Note: If you signed the CLA in the past then it's possible you used a different email or didn't provide your GitHub username at the time. You can login to https://cla.developers.google.com/ to double check. |
|
Very fast response! I just verified that the email address of the author of the original commit is already in the database (verified using the internal UI). Although my github username wasn't there. This page only lets me sign a new agreement, not double check my existing email as indicated by the previous comment: https://cla.developers.google.com/ |
|
I added a commit from a non-CLA email address to test the response when the opener+first committer has signed CLA, but a follow-up commit from an author who has not signed CLA. (But this doesn't matter until the verifier verifies that the original author has signed) |
|
yeah, right now it's not getting past the "pr sender has not signed a CLA" because it can't look you up with your github account. |
|
Added my Github account to CLA |
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
|
CLAs look good, thanks! |
|
Thanks! (I removed the bad commit) |
No description provided.