Add validation of keys to GroupByAggregator::ValidateInputs#5286
Merged
copybara-service[bot] merged 1 commit intomainfrom Feb 6, 2026
Merged
Add validation of keys to GroupByAggregator::ValidateInputs#5286copybara-service[bot] merged 1 commit intomainfrom
copybara-service[bot] merged 1 commit intomainfrom
Conversation
copybara-service
bot
force-pushed
the
cl/863385679
branch
from
389ada1 to
eeddd8e
Compare
Previously, type of the grouping keys given to GroupByAggregator::ValidateInputs could have been incorrect. Now, we call CompositeKeyCombiner::CheckValidAndGetShape to close that gap. PiperOrigin-RevId: 866607360
copybara-service
bot
force-pushed
the
cl/863385679
branch
from
eeddd8e to
0040bea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add validation of keys to GroupByAggregator::ValidateInputs
Previously, type of the grouping keys given to GroupByAggregator::ValidateInputs could have been incorrect. Now, we call CompositeKeyCombiner::CheckValidAndGetShape to close that gap.