Catch an edge case in DPGroupingFederatedSumFactory::CreateInternal: the linfinity parameter is negative but the input has type UINT64, which would cause a casting error.
#5272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
cl/839874063
branch
3 times, most recently
from
58b1d37 to
00ecd63
Compare
…: the `linfinity` parameter is negative but the input has type UINT64, which would cause a casting error. A negative `linfinity` value causes no clamping to occur. But a value of 0 also has this effect so when the edge case happens, this CL switches from casting to passing 0. PiperOrigin-RevId: 839874063
copybara-service
bot
force-pushed
the
cl/839874063
branch
from
00ecd63 to
33b7dd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catch an edge case in
DPGroupingFederatedSumFactory::CreateInternal: thelinfinityparameter is negative but the input has type UINT64, which would cause a casting error.A negative
linfinityvalue causes no clamping to occur. But a value of 0 also has this effect so when the edge case happens, this CL switches from casting to passing 0.