Skip to content

chore(release): allow bundling for all builds, including stable#24305

Merged
sehoon38 merged 1 commit intomainfrom
revert-pr-21821
Mar 31, 2026
Merged

chore(release): allow bundling for all builds, including stable#24305
sehoon38 merged 1 commit intomainfrom
revert-pr-21821

Conversation

@sehoon38
Copy link
Copy Markdown
Contributor

Summary

Revert #21821 to allow bundling for all builds, including stable builds.

Details

This PR removes the condition that restricted npm bundling to non-stable tags. Bundling will now occur for all builds, including those with the latest npm tag.

Related Issues

Reverts #21821

How to Validate

Verify the change in .github/actions/publish-release/action.yml:

  • Locate the step "Prepare bundled CLI for npm release".
  • Ensure the if condition is inputs.npm-registry-url != 'https://npm.pkg.github.com/'.

Pre-Merge Checklist

  • Updated relevant documentation and README (if needed)
  • Added/updated tests (if needed)
  • Noted breaking changes (if any)

@sehoon38 sehoon38 requested a review from a team as a code owner March 31, 2026 04:58
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change to ensure that the CLI bundling process is executed for all npm releases, regardless of the release tag. This change standardizes the release pipeline by ensuring consistent bundling behavior across both stable and non-stable builds.

Highlights

  • Bundling Configuration: Removed the conditional restriction that prevented npm bundling for stable builds marked with the 'latest' tag.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-cli
Copy link
Copy Markdown
Contributor

gemini-cli bot commented Mar 31, 2026

Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this.

We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines.

Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed.

Thank you for your understanding and for being a part of our community!

@github-actions
Copy link
Copy Markdown

Size Change: -4 B (0%)

Total Size: 26.5 MB

Filename Size Change
./bundle/chunk-OJOW2KAX.js 0 B -14.7 MB (removed) 🏆
./bundle/chunk-Q2346Z5O.js 0 B -3.78 MB (removed) 🏆
./bundle/core-W3ZCID7T.js 0 B -44.6 kB (removed) 🏆
./bundle/devtoolsService-VHWYTOEO.js 0 B -28.4 kB (removed) 🏆
./bundle/interactiveCli-OUBGRDUC.js 0 B -1.66 MB (removed) 🏆
./bundle/oauth2-provider-DT5WWMCM.js 0 B -9.16 kB (removed) 🏆
./bundle/chunk-3UVV5Z4N.js 3.78 MB +3.78 MB (new file) 🆕
./bundle/chunk-UANTREXU.js 14.7 MB +14.7 MB (new file) 🆕
./bundle/core-YIKK2EH7.js 44.6 kB +44.6 kB (new file) 🆕
./bundle/devtoolsService-LQ3YHJ5A.js 28.4 kB +28.4 kB (new file) 🆕
./bundle/interactiveCli-6PCP7KSM.js 1.66 MB +1.66 MB (new file) 🆕
./bundle/oauth2-provider-UKWZSZEH.js 9.16 kB +9.16 kB (new file) 🆕
ℹ️ View Unchanged
Filename Size
./bundle/chunk-34MYV7JD.js 2.45 kB
./bundle/chunk-5AUYMPVF.js 858 B
./bundle/chunk-664ZODQF.js 124 kB
./bundle/chunk-DAHVX5MI.js 206 kB
./bundle/chunk-IUUIT4SU.js 56.5 kB
./bundle/chunk-PTGY7UXW.js 1.96 MB
./bundle/chunk-RJTRUG2J.js 39.8 kB
./bundle/chunk-U4FACSVX.js 1.13 kB
./bundle/devtools-36NN55EP.js 696 kB
./bundle/dist-T73EYRDX.js 356 B
./bundle/events-CLX3JQHP.js 418 B
./bundle/gemini.js 532 kB
./bundle/getMachineId-bsd-TXG52NKR.js 1.55 kB
./bundle/getMachineId-darwin-7OE4DDZ6.js 1.55 kB
./bundle/getMachineId-linux-SHIFKOOX.js 1.34 kB
./bundle/getMachineId-unsupported-5U5DOEYY.js 1.06 kB
./bundle/getMachineId-win-6KLLGOI4.js 1.72 kB
./bundle/memoryDiscovery-4PHRORYM.js 980 B
./bundle/multipart-parser-KPBZEGQU.js 11.7 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/client/main.js 222 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/_client-assets.js 229 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/index.js 13.4 kB
./bundle/node_modules/@google/gemini-cli-devtools/dist/src/types.js 132 B
./bundle/sandbox-macos-permissive-open.sb 890 B
./bundle/sandbox-macos-permissive-proxied.sb 1.31 kB
./bundle/sandbox-macos-restrictive-open.sb 3.36 kB
./bundle/sandbox-macos-restrictive-proxied.sb 3.56 kB
./bundle/sandbox-macos-strict-open.sb 4.82 kB
./bundle/sandbox-macos-strict-proxied.sb 5.02 kB
./bundle/src-QVCVGIUX.js 47 kB
./bundle/tree-sitter-7U6MW5PS.js 274 kB
./bundle/tree-sitter-bash-34ZGLXVX.js 1.84 MB

compressed-size-action

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release action configuration in .github/actions/publish-release/action.yml. The condition for the 'Prepare bundled CLI for npm release' step has been modified to remove the restriction on the 'latest' npm tag, allowing the step to run for all tags when the registry is not GitHub Packages. I have no feedback to provide.

@gemini-cli gemini-cli bot added the 🔒 maintainer only ⛔ Do not contribute. Internal roadmap item. label Mar 31, 2026
@sehoon38 sehoon38 added this pull request to the merge queue Mar 31, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 31, 2026
@sehoon38 sehoon38 added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit 25af91e Mar 31, 2026
30 checks passed
@sehoon38 sehoon38 deleted the revert-pr-21821 branch March 31, 2026 19:00
kalenkevich pushed a commit to kalenkevich/gemini-cli that referenced this pull request Apr 3, 2026
afanty2021 pushed a commit to afanty2021/gemini-cli that referenced this pull request Apr 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🔒 maintainer only ⛔ Do not contribute. Internal roadmap item.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants