chore(release): allow bundling for all builds, including stable#24305
chore(release): allow bundling for all builds, including stable#24305
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change to ensure that the CLI bundling process is executed for all npm releases, regardless of the release tag. This change standardizes the release pipeline by ensuring consistent bundling behavior across both stable and non-stable builds. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Hi @sehoon38, thank you so much for your contribution to Gemini CLI! We really appreciate the time and effort you've put into this. We're making some updates to our contribution process to improve how we track and review changes. Please take a moment to review our recent discussion post: Improving Our Contribution Process & Introducing New Guidelines. Key Update: Starting January 26, 2026, the Gemini CLI project will require all pull requests to be associated with an existing issue. Any pull requests not linked to an issue by that date will be automatically closed. Thank you for your understanding and for being a part of our community! |
|
Size Change: -4 B (0%) Total Size: 26.5 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Code Review
This pull request updates the release action configuration in .github/actions/publish-release/action.yml. The condition for the 'Prepare bundled CLI for npm release' step has been modified to remove the restriction on the 'latest' npm tag, allowing the step to run for all tags when the registry is not GitHub Packages. I have no feedback to provide.
Summary
Revert #21821 to allow bundling for all builds, including stable builds.
Details
This PR removes the condition that restricted npm bundling to non-stable tags. Bundling will now occur for all builds, including those with the
latestnpm tag.Related Issues
Reverts #21821
How to Validate
Verify the change in
.github/actions/publish-release/action.yml:ifcondition isinputs.npm-registry-url != 'https://npm.pkg.github.com/'.Pre-Merge Checklist